Sign upLogin

LiteracyVolunteersOfMA/lvm-rails

View on GitHub
Star
app/controllers/tutors_controller.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method tutor_params has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def tutor_params
    params.require(:tutor).permit(
      :address1,
      :address2,
      :age_preference,
Severity: Major
Found in app/controllers/tutors_controller.rb - About 2 hrs to fix

    File tutors_controller.rb has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class TutorsController < ApplicationController
  before_action :ensure_coordinator_or_admin!
  before_action :set_tutor, only: %i[show edit]

  add_breadcrumb 'Home', :root_path
    Severity: Minor
    Found in app/controllers/tutors_controller.rb - About 2 hrs to fix

      Method index has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def index
    add_breadcrumb 'Tutors'

    @new_button = {
      text: 'Create New Tutor',
      Severity: Minor
      Found in app/controllers/tutors_controller.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def deleted_index
    ensure_admin!
    add_breadcrumb 'Deleted Tutors'

    @clickable_rows = true
        Severity: Minor
        Found in app/controllers/tutors_controller.rb and 1 other location - About 15 mins to fix
        app/controllers/students_controller.rb on lines 51..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status