Sign upLogin

LivInTheLookingGlass/ManifoldMarketManager

View on GitHub
Star
ManifoldMarketManager/application.py

Summary

Maintainability
C
1 day
Test Coverage
F
18%

File application.py has 455 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Contains functions which are needed to run the runner script, but nowhere else."""

from __future__ import annotations

from argparse import ArgumentParser, Namespace
Severity: Minor
Found in ManifoldMarketManager/application.py - About 6 hrs to fix

Function quick_import_command has 13 arguments (exceeds 6 allowed). Consider refactoring.
Wontfix

def quick_import_command(
Severity: Major
Found in ManifoldMarketManager/application.py - About 1 hr to fix

TODO found
Open

    # TODO: turn this into an event queue instead
Severity: Minor
Found in ManifoldMarketManager/application.py by fixme

TODO found
Open

    # TODO: add templates here
Severity: Minor
Found in ManifoldMarketManager/application.py by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    for scanner in AVAILABLE_SCANNERS:
        run_parser.add_argument(
            f'--enable-{scanner.replace(".", "-")}', dest='scanners', action='append_const', const=scanner
Severity: Minor
Found in ManifoldMarketManager/application.py and 1 other location - About 55 mins to fix
ManifoldMarketManager/application.py on lines 130..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    for scanner in AVAILABLE_SCANNERS:
        scan_parser.add_argument(
            f'--enable-{scanner.replace(".", "-")}', dest='scanners', action='append_const', const=scanner
Severity: Minor
Found in ManifoldMarketManager/application.py and 1 other location - About 55 mins to fix
ManifoldMarketManager/application.py on lines 138..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status