Sign upLogin

LobeTia/statszee

View on GitHub
Star
api/services/LineProtocolService.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function validate has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  validate(line) {
    if (typeof line !== 'string') return false
    const lineElement = line.split(' ')
    if (lineElement.length != 2 && lineElement.length != 3) return false
    if (isNaN(lineElement[1])) return false
Severity: Minor
Found in api/services/LineProtocolService.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        if (isNaN(timeDefinition[0])) return false
Severity: Major
Found in api/services/LineProtocolService.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return true
    Severity: Major
    Found in api/services/LineProtocolService.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              if (!this.testTimeFormat(timeDefinition[1])) return false
      Severity: Major
      Found in api/services/LineProtocolService.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                if (isNaN(timeDefinition[0])) return false
        Severity: Major
        Found in api/services/LineProtocolService.js - About 30 mins to fix

          TODO found
          Open

            // TODO: Choose a correct naming/format for timestamp & timeUnit
          Severity: Minor
          Found in api/services/LineProtocolService.js by fixme

          TODO found
          Open

            // TODO: Only accept full line (client must send complete lines)
          Severity: Minor
          Found in api/services/LineProtocolService.js by fixme

          TODO found
          Open

            // TODO: Refactor into a Point class and a PointArray class
          Severity: Minor
          Found in api/services/LineProtocolService.js by fixme

          TODO found
          Open

           * @description TODO document Service
          Severity: Minor
          Found in api/services/LineProtocolService.js by fixme

          There are no issues that match your filters.

          Category
          Status