Sign upLogin

LobeTia/statszee

View on GitHub
Star

Showing 32 of 32 total issues

Function validate has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  validate(line) {
    if (typeof line !== 'string') return false
    const lineElement = line.split(' ')
    if (lineElement.length != 2 && lineElement.length != 3) return false
    if (isNaN(lineElement[1])) return false
Severity: Minor
Found in api/services/LineProtocolService.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  get(req, res) {
    this.app.orm.Metric.findOne({
      where: {
        namespace: req.params.namespace,
        precision: req.params.precision
Severity: Minor
Found in api/controllers/api/1.0/StatsReaderController.js - About 1 hr to fix

    Function schema has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static schema(app, Sequelize) {
    return {
      metric: {
        type: Sequelize.BIGINT,
        index: true,
    Severity: Minor
    Found in api/models/Stat.js - About 1 hr to fix

      Function writePoint has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        writePoint(point) {
    return new Promise((fullfill, reject) => {

      // TODO: Add Memory-cache Stat findOrCreate (for priming new Stat rows)
      this.getMetricInstance(point)
      Severity: Minor
      Found in api/services/LineProtocolWriterService.js - About 1 hr to fix

        Function getMetricInstance has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          getMetricInstance(point) {
    const cache = this.app.services.CacheService.getCaches()

    return new Promise((fullfill, reject) => {
      cache.get(this.getCacheKey(point), (error, metric) => {
        Severity: Minor
        Found in api/services/LineProtocolWriterService.js - About 1 hr to fix

          Function write has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            write(req, res) {

    new Promise((fullfill, reject) => {
      if (!req.body)throw new ValidationError()
      let lines = this.app.services.LineProtocolService.explode(req.body);
          Severity: Minor
          Found in api/controllers/api/1.0/DataLoaderController.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (req.query.end) {
          query.where.datetime["$lte"] = moment(req.query.end, "x").toDate()
        }
            Severity: Minor
            Found in api/controllers/api/1.0/StatsReaderController.js and 1 other location - About 55 mins to fix
            api/controllers/api/1.0/StatsReaderController.js on lines 32..34

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (req.query.start) {
          query.where.datetime["$gte"] = moment(req.query.start, "x").toDate()
        }
            Severity: Minor
            Found in api/controllers/api/1.0/StatsReaderController.js and 1 other location - About 55 mins to fix
            api/controllers/api/1.0/StatsReaderController.js on lines 35..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function write has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              write(req, res) {

    new Promise((fullfill, reject) => {
      if (!req.body)throw new ValidationError()
      let lines = this.app.services.LineProtocolService.explode(req.body);
            Severity: Minor
            Found in api/controllers/api/1.0/DataLoaderController.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                    if (!this.testTimeFormat(timeDefinition[1])) return false
            Severity: Major
            Found in api/services/LineProtocolService.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return true
              Severity: Major
              Found in api/services/LineProtocolService.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        if (isNaN(timeDefinition[0])) return false
                Severity: Major
                Found in api/services/LineProtocolService.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          if (isNaN(timeDefinition[0])) return false
                  Severity: Major
                  Found in api/services/LineProtocolService.js - About 30 mins to fix

                    TODO found
                    Open

                     * @description TODO document Controller.
                    Severity: Minor
                    Found in api/controllers/api/1.0/DataLoaderController.js by fixme

                    TODO found
                    Open

                     * @description TODO document Controller.
                    Severity: Minor
                    Found in api/controllers/api/1.0/StatsReaderController.js by fixme

                    TODO found
                    Open

                     * @description TODO document Controller.
                    Severity: Minor
                    Found in api/controllers/api/HeartbeatController.js by fixme

                    TODO found
                    Open

                              // TODO: Remove ON CONFLICT and just use and UPDATE statement (if Stat findOrCreate is performed)
                    Severity: Minor
                    Found in api/services/LineProtocolWriterService.js by fixme

                    TODO found
                    Open

                      // TODO: Refactor into a Point class and a PointArray class
                    Severity: Minor
                    Found in api/services/LineProtocolService.js by fixme

                    TODO found
                    Open

                      // TODO: Only accept full line (client must send complete lines)
                    Severity: Minor
                    Found in api/services/LineProtocolService.js by fixme

                    TODO found
                    Open

                     * @description TODO document Controller.
                    Severity: Minor
                    Found in api/controllers/DashboardController.js by fixme
                    Severity
                    Category
                    Status
                    Source
                    Language