Sign upLogin

LoboEvolution/LoboEvolution

View on GitHub
Star
LoboCommon/src/main/java/org/loboevolution/common/EventDispatch2.java

Summary

Maintainability
A
30 mins
Test Coverage

Rename "listeners" which hides the field declared at line 41.
Open

            final Collection<EventListener> listeners = this.listeners;
Severity: Major
Found in LoboCommon/src/main/java/org/loboevolution/common/EventDispatch2.java by sonar-java

Overriding or shadowing a variable declared in an outer scope can strongly impact the readability, and therefore the maintainability, of a piece of code. Further, it could lead maintainers to introduce bugs because they think they're using one variable but are really using another.

Noncompliant Code Example

class Foo {
  public int myField;

  public void doSomething() {
    int myField = 0;
    ...
  }
}

See

Change the visibility of this constructor to "protected".
Open

    public EventDispatch2() {
Severity: Major
Found in LoboCommon/src/main/java/org/loboevolution/common/EventDispatch2.java by sonar-java

Abstract classes should not have public constructors. Constructors of abstract classes can only be called in constructors of their subclasses. So there is no point in making them public. The protected modifier should be enough.

Noncompliant Code Example

public abstract class AbstractClass1 {
    public AbstractClass1 () { // Noncompliant, has public modifier
        // do something here
    }
}

Compliant Solution

public abstract class AbstractClass2 {
    protected AbstractClass2 () {
        // do something here
    }
}

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public final void addListener(final EventListener listener) {
        synchronized (this) {
            if (this.listeners == null) {
                this.listeners = createListenerCollection();
            }
Severity: Minor
Found in LoboCommon/src/main/java/org/loboevolution/common/EventDispatch2.java and 1 other location - About 30 mins to fix
LoboCommon/src/main/java/org/loboevolution/common/EventDispatch.java on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status