Sign upLogin

LoboEvolution/LoboEvolution

View on GitHub
Star
LoboCommon/src/main/java/org/loboevolution/common/GUITasks.java

Summary

Maintainability
C
1 day
Test Coverage

Method drawDashed has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    public static void drawDashed(final Graphics g, final int xDashed1, final int yDashed1, final int xDashed2, final int yDashed2, final int dashSize, final int gapSize) {
        int x1 = xDashed1;
        int y1 = yDashed1;
        int x2 = xDashed2;
        int y2 = yDashed2;
Severity: Minor
Found in LoboCommon/src/main/java/org/loboevolution/common/GUITasks.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method drawDashed has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static void drawDashed(final Graphics g, final int xDashed1, final int yDashed1, final int xDashed2, final int yDashed2, final int dashSize, final int gapSize) {
        int x1 = xDashed1;
        int y1 = yDashed1;
        int x2 = xDashed2;
        int y2 = yDashed2;
Severity: Minor
Found in LoboCommon/src/main/java/org/loboevolution/common/GUITasks.java - About 1 hr to fix

    Method drawDashed has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static void drawDashed(final Graphics g, final int xDashed1, final int yDashed1, final int xDashed2, final int yDashed2, final int dashSize, final int gapSize) {
    Severity: Major
    Found in LoboCommon/src/main/java/org/loboevolution/common/GUITasks.java - About 50 mins to fix

      Method drawDotted has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static void drawDotted(final Graphics g, final int x1, final int y1, final int x2, final int y2, final float width) {
      Severity: Minor
      Found in LoboCommon/src/main/java/org/loboevolution/common/GUITasks.java - About 45 mins to fix

        Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
        Open

            public static void drawDashed(final Graphics g, final int xDashed1, final int yDashed1, final int xDashed2, final int yDashed2, final int dashSize, final int gapSize) {
        Severity: Critical
        Found in LoboCommon/src/main/java/org/loboevolution/common/GUITasks.java by sonar-java

        Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

        See

        Add a private constructor to hide the implicit public one.
        Open

        public class GUITasks {
        Severity: Major
        Found in LoboCommon/src/main/java/org/loboevolution/common/GUITasks.java by sonar-java

        Utility classes, which are collections of static members, are not meant to be instantiated. Even abstract utility classes, which can be extended, should not have public constructors.

        Java adds an implicit public constructor to every class which does not define at least one explicitly. Hence, at least one non-public constructor should be defined.

        Noncompliant Code Example

        class StringUtils { // Noncompliant

  public static String concatenate(String s1, String s2) {
    return s1 + s2;
  }

}

        Compliant Solution

        class StringUtils { // Compliant

  private StringUtils() {
    throw new IllegalStateException("Utility class");
  }

  public static String concatenate(String s1, String s2) {
    return s1 + s2;
  }

}

        Exceptions

        When class contains public static void main(String[] args) method it is not considered as utility class and will be ignored by this rule.

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                } else if (x1 == x2) {
            final int virtualStartY = y1 / totalDash * totalDash;
            for (int y = virtualStartY; y < y2; y += totalDash) {
                int topY = y + dashSize;
                if (topY > y2) {
        Severity: Major
        Found in LoboCommon/src/main/java/org/loboevolution/common/GUITasks.java and 1 other location - About 1 hr to fix
        LoboCommon/src/main/java/org/loboevolution/common/GUITasks.java on lines 66..81

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 120.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if (y1 == y2) {
            final int virtualStartX = x1 / totalDash * totalDash;
            for (int x = virtualStartX; x < x2; x += totalDash) {
                int topX = x + dashSize;
                if (topX > x2) {
        Severity: Major
        Found in LoboCommon/src/main/java/org/loboevolution/common/GUITasks.java and 1 other location - About 1 hr to fix
        LoboCommon/src/main/java/org/loboevolution/common/GUITasks.java on lines 81..96

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 120.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status