Sign upLogin

LoboEvolution/LoboEvolution

View on GitHub
Star
LoboXalan/src/main/java/org/loboevolution/apache/xpath/res/XPATHErrorResources.java

Summary

Maintainability
F
3 days
Test Coverage

Method getContents has 436 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public Object[][] getContents() {
        return new Object[][]{

                {"ERROR0000", "{0}"},
Severity: Major
Found in LoboXalan/src/main/java/org/loboevolution/apache/xpath/res/XPATHErrorResources.java - About 2 days to fix

    File XPATHErrorResources.java has 724 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * MIT License
 *
 * Copyright (c) 2014 - 2024 LoboEvolution
 *
    Severity: Major
    Found in LoboXalan/src/main/java/org/loboevolution/apache/xpath/res/XPATHErrorResources.java - About 1 day to fix

      Use already-defined constant 'BAD_CODE' instead of duplicating its value here.
      Open

                      {"BAD_CODE", "Parameter to createMessage was out of bounds"},
      Severity: Critical
      Found in LoboXalan/src/main/java/org/loboevolution/apache/xpath/res/XPATHErrorResources.java by sonar-java

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

      Compliant Solution

      private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Use already-defined constant 'FORMAT_FAILED' instead of duplicating its value here.
      Open

                      {"FORMAT_FAILED", "Exception thrown during messageFormat call"},
      Severity: Critical
      Found in LoboXalan/src/main/java/org/loboevolution/apache/xpath/res/XPATHErrorResources.java by sonar-java

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

      Compliant Solution

      private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      There are no issues that match your filters.

      Category
      Status