Sign upLogin

LogicalOverflow/music-sync

View on GitHub
Star

Showing 7 of 7 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if passed != 0 {
        copy(s.Chunks, s.Chunks[passed:])
        for i := len(s.Chunks) - passed; i < len(s.Chunks); i++ {
            s.Chunks[i] = upcomingChunk{}
        }
Severity: Minor
Found in cmd/music-sync-infoer/state.go and 1 other location - About 35 mins to fix
cmd/music-sync-infoer/state.go on lines 125..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if 0 < passed {
        copy(s.Pauses, s.Pauses[passed:])
        for i := len(s.Pauses) - passed; i < len(s.Pauses); i++ {
            s.Pauses[i] = pauseToggle{}
        }
Severity: Minor
Found in cmd/music-sync-infoer/state.go and 1 other location - About 35 mins to fix
cmd/music-sync-infoer/state.go on lines 179..185

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func TestState_currentSong(t *testing.T) {
    schedule.SampleRate = testSampleRate
    for _, c := range currentSongCases {
        state := state{Songs: c.songs}
        actual := state.currentSong(c.sample)
Severity: Minor
Found in cmd/music-sync-infoer/state_test.go and 1 other location - About 35 mins to fix
cmd/music-sync-infoer/state_test.go on lines 19..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func TestState_currentSample(t *testing.T) {
    schedule.SampleRate = testSampleRate
    for _, c := range currentSampleCases {
        state := state{Chunks: c.chunks}
        actual := state.currentSample(c.now)
Severity: Minor
Found in cmd/music-sync-infoer/state_test.go and 1 other location - About 35 mins to fix
cmd/music-sync-infoer/state_test.go on lines 28..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

2: cannot find package "github.com/LogicalOverflow/music-sync/logging" in any of:
Open

    "github.com/LogicalOverflow/music-sync/logging"
Severity: Minor
Found in cmd/flags.go by govet

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Package playback contains functions and types to stream and play audio
Severity: Minor
Found in playback/playback.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

package log
Severity: Minor
Found in logging/level.go by gofmt
Severity
Category
Status
Source
Language