Luavis/sherlock

View on GitHub
sherlock/codelib/generator/__init__.py

Summary

Maintainability
C
7 hrs
Test Coverage

Function generate has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    def generate(self):
        if self.node is None:
            self.node = ast.parse(self.code)
        if isinstance(self.node, ast.Module):
            for x in self.node.body:
Severity: Minor
Found in sherlock/codelib/generator/__init__.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_type has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def get_type(self, node):
        if isinstance(node, ast.Num):
            return Type.NUMBER
        elif isinstance(node, ast.Str):
            return Type.STRING
Severity: Minor
Found in sherlock/codelib/generator/__init__.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(
Severity: Minor
Found in sherlock/codelib/generator/__init__.py - About 45 mins to fix

    Avoid too many return statements within this function.
    Open

                return Type.VOID
    Severity: Major
    Found in sherlock/codelib/generator/__init__.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return Type.NUMBER
      Severity: Major
      Found in sherlock/codelib/generator/__init__.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return self.functions[node.func.id].return_type
        Severity: Major
        Found in sherlock/codelib/generator/__init__.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return Type.STRING
          Severity: Major
          Found in sherlock/codelib/generator/__init__.py - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status