Sign upLogin

Lullabot/mpx-php

View on GitHub
Star

Showing 5 of 28 total issues

FeedConfig has 84 functions (exceeds 20 allowed). Consider refactoring.
Open

class FeedConfig extends ObjectBase implements PublicIdWithGuidInterface
{
    /**
     * The parameters that are passed to a custom feed adapter for processing at runtime.
     *
Severity: Major
Found in src/DataService/Feeds/FeedConfig.php - About 1 day to fix

    File FeedConfig.php has 412 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Lullabot\Mpx\DataService\Feeds;

use GuzzleHttp\Psr7\Uri;
    Severity: Minor
    Found in src/DataService/Feeds/FeedConfig.php - About 5 hrs to fix

      Avoid deeply nested control flow statements.
      Open

                                  if ('{' === $token
                                || \T_CURLY_OPEN === $token->id
                                || \T_DOLLAR_OPEN_CURLY_BRACES === $token->id) {
                                if (!$firstBraceFound) {
                                    $firstBraceFound = true;
      Severity: Major
      Found in src/DataService/CachingContextFactory.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    if ('}' === $token) {
                                --$braceLevel;
                            }
        Severity: Major
        Found in src/DataService/CachingContextFactory.php - About 45 mins to fix

          Function decodeCustomFields has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Confirmed

              protected function decodeCustomFields(&$decoded)
    {
        // @todo This is O(namespaces * entries) and can be optimized.
        foreach ($decoded['$xmlns'] as $prefix => $namespace) {
            if (!isset($decoded['entries'])) {
          Severity: Minor
          Found in src/Encoder/CJsonEncoder.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language