Lullabot/mpx-php

View on GitHub
src/DataService/CachingContextFactory.php

Summary

Maintainability
A
1 hr
Test Coverage
A
100%

Function createForNamespace has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Wontfix

    public function createForNamespace($namespace, $fileContents)
    {
        static $cache = [];
        $key = md5($fileContents);

Severity: Minor
Found in src/DataService/CachingContextFactory.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createForNamespace has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    public function createForNamespace($namespace, $fileContents)
    {
        static $cache = [];
        $key = md5($fileContents);

Severity: Minor
Found in src/DataService/CachingContextFactory.php - About 1 hr to fix

    Function extractUseStatement has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Wontfix

        private function extractUseStatement(\ArrayIterator $tokens)
        {
            $result = [''];
            while ($tokens->valid()
                && (self::T_LITERAL_USE_SEPARATOR !== $tokens->current()->id)
    Severity: Minor
    Found in src/DataService/CachingContextFactory.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                                if ('{' === $token
                                    || \T_CURLY_OPEN === $token->id
                                    || \T_DOLLAR_OPEN_CURLY_BRACES === $token->id) {
                                    if (!$firstBraceFound) {
                                        $firstBraceFound = true;
    Severity: Major
    Found in src/DataService/CachingContextFactory.php - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if ('}' === $token) {
                                      --$braceLevel;
                                  }
      Severity: Major
      Found in src/DataService/CachingContextFactory.php - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status