Sign upLogin

ML-Jason/ml.vartool

View on GitHub
Star

Showing 8 of 21 total issues

Function url has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

vcheck.url = (str, { localhost = true, wildcard = false, protocols = ['http', 'https'] } = {}) => {
  const protocolsAllow = Array.isArray(protocols) ? protocols.map((v) => v.toString()) : ['http', 'https'];
  const rs = vcheck.str(str);
  let protocol = '';
  let tmpurl = rs;
Severity: Minor
Found in src/vcheck.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

vcheck.email = (str) => {
  const rs = vcheck.normalStr(str);
  if (validator.isEmail(rs)) return rs;
  return '';
};
Severity: Minor
Found in src/vcheck.js and 1 other location - About 55 mins to fix
src/vcheck.js on lines 75..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

vcheck.mongoID = (str) => {
  const rs = vcheck.str(str);
  if (validator.isMongoId(rs)) return rs;
  return '';
};
Severity: Minor
Found in src/vcheck.js and 1 other location - About 55 mins to fix
src/vcheck.js on lines 63..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

  return '';
Severity: Major
Found in src/vcheck.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        if (globalNames.includes(ns[1])) return '';
    Severity: Major
    Found in src/vcheck.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        if (validator.isURL(protocol ? `${protocol}://${tmpurl}` : tmpurl, { protocols: protocolsAllow })) return rs;
      Severity: Major
      Found in src/vcheck.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          } else if (globalNames.includes(ns[0])) return '';
        Severity: Major
        Found in src/vcheck.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              if (ns.length <= 2) return '';
          Severity: Major
          Found in src/vcheck.js - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language