Sign upLogin

MPOS/php-mpos

View on GitHub
Star
include/classes/base.class.php

Summary

Maintainability
C
7 hrs
Test Coverage

Base has 42 functions (exceeds 20 allowed). Consider refactoring.
Open

class Base {
  private $sError = '';
  private $sCronError = '';
  protected $table = '';
  private $values = array(), $types = '';
Severity: Minor
Found in include/classes/base.class.php - About 5 hrs to fix

    Method getSingle has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      protected function getSingle($value, $search='id', $field='id', $type="i", $lower=false) {
    Severity: Minor
    Found in include/classes/base.class.php - About 35 mins to fix

      Function getErrorMsg has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        public function getErrorMsg($errCode='') {
    if (!is_array($this->aErrorCodes)) return 'Error codes not loaded';
    if (!array_key_exists($errCode, $this->aErrorCodes)) return 'Unknown Error Code: ' . $errCode;
    if (func_num_args() > 1) {
      $args = func_get_args();
      Severity: Minor
      Found in include/classes/base.class.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return $this->aErrorCodes[$errCode];
      Severity: Major
      Found in include/classes/base.class.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status