MPOS/php-mpos

View on GitHub
include/classes/invitation.class.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method sendInvitation has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public function sendInvitation($account_id, $aData) {
    $this->debug->append("STA " . __METHOD__, 4);
    // Check data input
    if (empty($aData['email']) || !filter_var($aData['email'], FILTER_VALIDATE_EMAIL)) {
      $this->setErrorMessage($this->getErrorMsg('E0023'));
Severity: Minor
Found in include/classes/invitation.class.php - About 1 hr to fix

    Function sendInvitation has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      public function sendInvitation($account_id, $aData) {
        $this->debug->append("STA " . __METHOD__, 4);
        // Check data input
        if (empty($aData['email']) || !filter_var($aData['email'], FILTER_VALIDATE_EMAIL)) {
          $this->setErrorMessage($this->getErrorMsg('E0023'));
    Severity: Minor
    Found in include/classes/invitation.class.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return false;
    Severity: Major
    Found in include/classes/invitation.class.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return true;
      Severity: Major
      Found in include/classes/invitation.class.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return false;
        Severity: Major
        Found in include/classes/invitation.class.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return false;
          Severity: Major
          Found in include/classes/invitation.class.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status