Sign upLogin

MPOS/php-mpos

View on GitHub
Star
include/classes/pushnotification.class.php

Summary

Maintainability
C
1 day
Test Coverage

Function getNotificatorInstance has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        public function getNotificatorInstance($notificator, $data){
            $class = null;
            $file = null;
            
            if (is_array($notificator)){
Severity: Minor
Found in include/classes/pushnotification.class.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getClasses has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

        public function getClasses(){
            if (self::$classes === null){
                $directory = new DirectoryIterator(__DIR__.'/push_notification');
                foreach ($directory as $fileInfo) {
                    if (($fileInfo->getExtension() != 'php') || $fileInfo->isDot()) {
Severity: Minor
Found in include/classes/pushnotification.class.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sendNotification has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

        public function sendNotification($account_id, $template, $aData){
            $settings = $this->getNotificationSettings($account_id);
            if ($settings['class']){
                $instance = $this->getNotificatorInstance(array($settings['class'], $settings['file']), $settings['params']);
                if ($instance){
Severity: Minor
Found in include/classes/pushnotification.class.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getNotificatorInstance has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function getNotificatorInstance($notificator, $data){
            $class = null;
            $file = null;
            
            if (is_array($notificator)){
Severity: Minor
Found in include/classes/pushnotification.class.php - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status