Sign upLogin

MPOS/php-mpos

View on GitHub
Star
include/pages/admin/checks/check_stratum.inc.php

Summary

Maintainability
A
40 mins
Test Coverage

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  if (! $fp = @fsockopen($config['gettingstarted']['stratumurl'], $config['gettingstarted']['stratumport'], $errCode, $errStr, 1)) {
    $newerror = array();
    $newerror['name'] = "Stratum information";
    $newerror['level'] = 1;
    $newerror['extdesc'] = "We tried to connect the stratum server that you set in your gettingstarted config, but an error occured somewhere along the way. Your stratum server may not be running currently, your firewall could be blocking the connection, or your coin daemon may not yet be fully synced, etc.";
Severity: Major
Found in include/pages/admin/checks/check_stratum.inc.php and 9 other locations - About 40 mins to fix
include/pages/admin/checks/check_daemon.inc.php on lines 6..54
include/pages/admin/checks/check_daemon.inc.php on lines 18..28
include/pages/admin/checks/check_fees.inc.php on lines 5..15
include/pages/admin/checks/check_memcache.inc.php on lines 5..15
include/pages/admin/checks/check_memcache.inc.php on lines 33..53
include/pages/admin/checks/check_memcache.inc.php on lines 43..53
include/pages/admin/checks/check_memcache.inc.php on lines 57..67
include/pages/admin/checks/check_permissions.inc.php on lines 6..16
include/pages/admin/checks/check_permissions.inc.php on lines 44..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status