MPOS/php-mpos

Method `_bodyToByteStream` has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _bodyToByteStream(Swift_InputByteStream $is)
    {
        if (empty($this->_immediateChildren)) {
            if (isset($this->_body)) {
                if ($this->_cache->hasKey($this->_cacheKey, 'body')) {

Found in include/lib/swiftmailer/classes/Swift/Mime/SimpleMimeEntity.php - About 1 hr to fix

Method `_doHeloCommand` has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _doHeloCommand()
    {
        try {
            $response = $this->executeCommand(
                sprintf("EHLO %s\r\n", $this->_domain), array(250)

Found in include/lib/swiftmailer/classes/Swift/Transport/EsmtpTransport.php - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    $this->_retvalue = $this->compiler->compileTag('for',array_merge($this->yystack[$this->yyidx + 0]->minor,array(array('start'=>$this->yystack[$this->yyidx + -5]->minor),array('to'=>$this->yystack[$this->yyidx + -3]->minor),array('step'=>$this->yystack[$this->yyidx + -1]->minor))),0);

Found in include/smarty/libs/sysplugins/smarty_internal_templateparser.php and 1 other location - About 1 hr to fix

Read up
Read up

include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 2458..2458

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    $this->_retvalue = $this->compiler->compileTag('foreach',array_merge($this->yystack[$this->yyidx + 0]->minor,array(array('from'=>$this->yystack[$this->yyidx + -7]->minor),array('item'=>$this->yystack[$this->yyidx + -1]->minor),array('key'=>$this->yystack[$this->yyidx + -4]->minor))));

Found in include/smarty/libs/sysplugins/smarty_internal_templateparser.php and 1 other location - About 1 hr to fix

Read up
Read up

include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 2443..2443

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Method `smarty_function_html_checkboxes_output` has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

function smarty_function_html_checkboxes_output($name, $value, $output, $selected, $extra, $separator, $labels, $label_ids, $escape=true)

Found in include/smarty/libs/plugins/function.html_checkboxes.php - About 1 hr to fix

Method `smarty_function_html_radios_output` has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

function smarty_function_html_radios_output($name, $value, $output, $selected, $extra, $separator, $labels, $label_ids, $escape)

Found in include/smarty/libs/plugins/function.html_radios.php - About 1 hr to fix

Method `register` has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

  public function register($username, $coinaddress, $password1, $password2, $pin, $email1='', $email2='', $tac='', $strToken='') {

Found in include/classes/user.class.php - About 1 hr to fix

Function `_hide` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        value: function _hide(element) {

          if (this._transitioning || !$(element).hasClass(this._config.collapseInClass)) {
            return;
          }

Found in public/site_assets/bootstrap/js/plugins/metisMenu/jquery.metisMenu.js - About 1 hr to fix

Method `run_0013` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function run_0013() {
  // Ugly but haven't found a better way
  global $setting, $config, $user, $mysqli;

  // Version information

Found in upgrade/definitions/0.0.12_to_0.0.13.inc.php - About 1 hr to fix

Method `compile` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function compile($args, $compiler, $parameter)
    {
        // check and get attributes
        $_attr = $this->getAttributes($compiler, $args);
        $this->openTag($compiler, 'while', $compiler->nocache);

Found in include/smarty/libs/sysplugins/smarty_internal_compile_while.php - About 1 hr to fix

Method `compile` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function compile($args, $compiler, $parameter)
    {
        // check and get attributes
        $_attr = $this->getAttributes($compiler, $args);
        $this->openTag($compiler, 'if', array(1, $compiler->nocache));

Found in include/smarty/libs/sysplugins/smarty_internal_compile_if.php - About 1 hr to fix

Method `generatePin` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public function generatePin($userID, $current) {
    $this->debug->append("STA " . __METHOD__, 4);
    $username = $this->getUserName($userID);
    $email = $this->getUserEmail($username);
    $strPasswordHash = $this->getUserPasswordHashById($userID);

Found in include/classes/user.class.php - About 1 hr to fix

Method `getAPQueue` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public function getAPQueue($limit=250) {
    $this->debug->append("STA " . __METHOD__, 4);
    $stmt = $this->mysqli->prepare("
      SELECT
        a.id,

Found in include/classes/transaction.class.php - About 1 hr to fix

Method `stripLinkDefinitions` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function stripLinkDefinitions($text) {
    #
    # Strips link definitions from text, stores the URLs and titles in
    # hash references.
    #

Found in include/lib/Michelf/Markdown.php - About 1 hr to fix

Function `getVariable` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function getVariable($variable, $_ptr = null, $search_parents = true, $error_enable = true)
    {
        if ($_ptr === null) {
            $_ptr = $this;
        } while ($_ptr !== null) {

Found in include/smarty/libs/sysplugins/smarty_internal_data.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `compile` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function compile($args, $compiler, $parameter)
    {
        static $_is_loopy = array('for' => true, 'foreach' => true, 'while' => true, 'section' => true);
        // check and get attributes
        $_attr = $this->getAttributes($compiler, $args);

Found in include/smarty/libs/sysplugins/smarty_internal_compile_break.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `__get` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function __get($property_name)
    {
        switch ($property_name) {
            case 'source':
                if (strlen($this->template_resource) == 0) {

Found in include/smarty/libs/sysplugins/smarty_internal_template.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `start_compile` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public static function start_compile($template)
    {
        static $_is_stringy = array('string' => true, 'eval' => true);
        if (!empty($template->compiler->trace_uid)) {
            $key = $template->compiler->trace_uid;

Found in include/smarty/libs/sysplugins/smarty_internal_debug.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `_count` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function _count($value)
    {
        if (is_array($value) === true || $value instanceof Countable) {
            return count($value);
        } elseif ($value instanceof IteratorAggregate) {

Found in include/smarty/libs/sysplugins/smarty_internal_template.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `compile` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function compile($args, $compiler)
    {
        // check and get attributes
        $_attr = $this->getAttributes($compiler, $args);
        if ($_attr['nocache'] === true) {

Found in include/smarty/libs/sysplugins/smarty_internal_compile_extends.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading