Sign upLogin

MPOS/php-mpos

View on GitHub
Star

Showing 1,089 of 1,089 total issues

Avoid too many return statements within this method.
Open

    return false;
Severity: Major
Found in include/classes/user.class.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return false;
    Severity: Major
    Found in include/classes/user.class.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in include/classes/user.class.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in include/classes/user.class.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return $this->sqlError();
          Severity: Major
          Found in include/classes/statistics.class.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return $this->sqlError();
            Severity: Major
            Found in include/classes/statistics.class.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return false;
              Severity: Major
              Found in include/classes/invitation.class.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return false;
                Severity: Major
                Found in include/classes/user.class.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return false;
                  Severity: Major
                  Found in include/classes/user.class.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                          return false;
                    Severity: Major
                    Found in include/classes/user.class.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return true;
                      Severity: Major
                      Found in include/classes/user.class.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                            return $this->sqlError();
                        Severity: Major
                        Found in include/classes/statistics.class.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                return $remote;
                          Severity: Major
                          Found in include/classes/user.class.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                return $this->sqlError();
                            Severity: Major
                            Found in include/classes/statistics.class.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return "$time - WARN -->";
                              Severity: Major
                              Found in include/lib/KLogger.php - About 30 mins to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    if (isset($params['time']) && is_array($params['time'])) {
        if (isset($params['time'][$prefix . 'Year'])) {
            // $_REQUEST[$field_array] given
            foreach (array('Y' => 'Year',  'm' => 'Month', 'd' => 'Day') as $_elementKey => $_elementName) {
                $_variableName = '_' . strtolower($_elementName);
                                Severity: Minor
                                Found in include/smarty/libs/plugins/function.html_select_date.php and 1 other location - About 30 mins to fix
                                include/smarty/libs/plugins/function.html_select_time.php on lines 151..190

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 90.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                            foreach (array('H' => 'Hour',  'i' => 'Minute', 's' => 'Second') as $_elementKey => $_elementName) {
                $_variableName = '_' . strtolower($_elementName);
                $$_variableName = isset($params['time'][$prefix . $_elementName])
                    ? $params['time'][$prefix . $_elementName]
                    : date($_elementKey);
                                Severity: Minor
                                Found in include/smarty/libs/plugins/function.html_select_time.php and 1 other location - About 30 mins to fix
                                include/smarty/libs/plugins/function.html_select_date.php on lines 184..189

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 90.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                            if ($expected) {
                $status = false;
                $message = "FAILED: files missing from libs/sysplugins: ". join(', ', array_keys($expected));
                if ($errors === null) {
                    echo $message . ".\n";
                                Severity: Minor
                                Found in include/smarty/libs/sysplugins/smarty_internal_utility.php and 1 other location - About 30 mins to fix
                                include/smarty/libs/sysplugins/smarty_internal_utility.php on lines 794..804

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 90.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                            foreach (array('Y' => 'Year',  'm' => 'Month', 'd' => 'Day') as $_elementKey => $_elementName) {
                $_variableName = '_' . strtolower($_elementName);
                $$_variableName = isset($params['time'][$prefix . $_elementName])
                    ? $params['time'][$prefix . $_elementName]
                    : date($_elementKey);
                                Severity: Minor
                                Found in include/smarty/libs/plugins/function.html_select_date.php and 1 other location - About 30 mins to fix
                                include/smarty/libs/plugins/function.html_select_time.php on lines 154..159

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 90.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Avoid too many return statements within this method.
                                Open

                                                return "$time - ERROR -->";
                                Severity: Major
                                Found in include/lib/KLogger.php - About 30 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language