MTG/dunya-desktop

View on GitHub
dunyadesktop_app/cultures/makam/featureparsers.py

Summary

Maintainability
A
0 mins
Test Coverage

Multiple spaces after operator
Open

    FEATURES =  ['melodic_progression', 'metadata', 'note_models', 'pitch'

Avoid extraneous whitespace around an operator.

Okay: a = 12 + 3
E221: a = 4  + 5
E222: a = 4 +  5
E223: a = 4\t+ 5
E224: a = 4 +\t5

Continuation line over-indented for visual indent
Open

                    'audioanalysis--metadata.json'

Continuation lines indentation.

Continuation lines should align wrapped elements either vertically
using Python's implicit line joining inside parentheses, brackets
and braces, or using a hanging indent.

When using a hanging indent these considerations should be applied:
- there should be no arguments on the first line, and
- further indentation should be used to clearly distinguish itself
  as a continuation line.

Okay: a = (\n)
E123: a = (\n    )

Okay: a = (\n    42)
E121: a = (\n   42)
E122: a = (\n42)
E123: a = (\n    42\n    )
E124: a = (24,\n     42\n)
E125: if (\n    b):\n    pass
E126: a = (\n        42)
E127: a = (24,\n      42)
E128: a = (24,\n    42)
E129: if (a or\n    b):\n    pass
E131: a = (\n    42\n 24)

No newline at end of file
Open

    os.system('ffmpeg -i {0} {1}'.format(input_f, output_f))

Trailing blank lines are superfluous.

Okay: spam(1)
W391: spam(1)\n

However the last line should end with a new line (warning W292).

There are no issues that match your filters.

Category
Status