Sign upLogin

MTG/dunya-desktop

View on GitHub
Star
dunyadesktop_app/cultures/makam/svgparser.py

Summary

Maintainability
A
1 hr
Test Coverage

Function change_color has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def change_color(path, tree, root, note_id, color):
Severity: Minor
Found in dunyadesktop_app/cultures/makam/svgparser.py - About 35 mins to fix

    Function change_color has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def change_color(path, tree, root, note_id, color):
    note_id = 'note-' + str(note_id)
    for a in root.findall(SVG_NS + 'a'):
        if 'id' in a.attrib:
            if a.attrib['id'] == note_id:
    Severity: Minor
    Found in dunyadesktop_app/cultures/makam/svgparser.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Expected 2 blank lines after class or function definition, found 1
    Open

    SVG_NS = '{http://www.w3.org/2000/svg}'
    Severity: Minor
    Found in dunyadesktop_app/cultures/makam/svgparser.py by pep8

    Separate top-level function and class definitions with two blank lines.

    Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

    There are no issues that match your filters.

    Category
    Status