MaazAli/phanime

Function getMALUserList has 167 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    getMALUserList: function(xmlContent) {

        // The user must be logged in for this function
        if (!Meteor.user())
            throw new Meteor.Error('user-required', 'User must be logged in to import MAL list');

Consider simplifying this complex logical expression.

Open

                if (!anime.series_title || !anime.series_animedb_id || !anime.my_watched_episodes || !anime.my_start_date || !anime.my_finish_date || !anime.my_score || !anime.my_status || !anime.my_rewatching || !anime.my_comments)
                    throw new Meteor.Error('mal-import-failed', 'XML file format is different than expected');

Avoid deeply nested control flow statements.

Open

                                    if (animeId && coverImageUrl) {
                                        console.log('We\'re about to upload the image');
                                        Meteor.call("uploadImageFromUrl", coverImageUrl, 'anime', 'cover', animeId, function(error, result) {
                                            if (error) {
                                                throw new Meteor.Error(403, error.reason);

Avoid deeply nested control flow statements.

Open

                                    if (LibraryEntries.simpleSchema().namedContext().validate(libraryEntry) === false) {
                                        // if validation failed, we should continue on with adding the entries, but we should push the invalid keys object into an array.
                                        importStats.failedImports++;

                                        var invalidKeys = LibraryEntries.simpleSchema().namedContext().invalidKeys();

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                        if (LibraryEntries.simpleSchema().namedContext().validate(libraryEntry) === false) {
                            // if validation failed, we should continue on with adding the entries, but we should push the invalid keys object into an array.
                            importStats.failedImports++;

                            var invalidKeys = LibraryEntries.simpleSchema().namedContext().invalidKeys();

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                                    if (LibraryEntries.simpleSchema().namedContext().validate(libraryEntry) === false) {
                                        // if validation failed, we should continue on with adding the entries, but we should push the invalid keys object into an array.
                                        importStats.failedImports++;

                                        var invalidKeys = LibraryEntries.simpleSchema().namedContext().invalidKeys();

• Read up
  Read up