Sign upLogin

MacroPower/wakatime_exporter

View on GitHub
Star

Showing 5 of 5 total issues

Method summaryCollector.Update has 82 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *summaryCollector) Update(ch chan<- prometheus.Metric) error {
    params := url.Values{}
    params.Add("start", "today")
    params.Add("end", "today")
    params.Add("cache", "false")
Severity: Major
Found in collector/summary.go - About 2 hrs to fix

    Function main has 75 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func main() {
    var (
        disableDefaultCollectors = kingpin.Flag(
            "collector.disable-defaults",
            "Set all collectors to disabled by default.",
    Severity: Minor
    Found in main.go - About 2 hrs to fix

      Method goalCollector.Update has 55 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (c *goalCollector) Update(ch chan<- prometheus.Metric) error {
    params := url.Values{}
    params.Add("cache", "false")

    body, fetchErr := c.fetchStat(c.uri, goalEndpoint, params)
      Severity: Minor
      Found in collector/goal.go - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func NewLeaderCollector(in CommonInputs, logger log.Logger) (Collector, error) {
    return &leaderCollector{
        rank: prometheus.NewDesc(
            prometheus.BuildFQName(namespace, leaderSubsystem, "rank"),
            "Current rank of the user.",
        Severity: Minor
        Found in collector/leader.go and 1 other location - About 40 mins to fix
        collector/all-time.go on lines 46..57

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 111.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func NewAllTimeCollector(in CommonInputs, logger log.Logger) (Collector, error) {
    return &alltimeCollector{
        total: prometheus.NewDesc(
            prometheus.BuildFQName(namespace, allTimeSubsystem, "seconds_total"),
            "Total seconds (all time).",
        Severity: Minor
        Found in collector/all-time.go and 1 other location - About 40 mins to fix
        collector/leader.go on lines 45..56

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 111.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language