MailOnline/videojs-vast-vpaid

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it("must add the InLine to the response if the passed ad has an InLine", function(){
        var vastJTree = xml.toJXONTree('<VAST><Ad><InLine></InLine></Ad></VAST>');
        var ad = new Ad(vastJTree.ad);
        sinon.stub(response, '_addInLine');
        response.addAd(ad);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it("must return false if you don't pass a valid string", function () {
    assert.isFalse(utilities.isNotEmptyString());
    assert.isFalse(utilities.isNotEmptyString({}));
    assert.isFalse(utilities.isNotEmptyString([]));
    assert.isFalse(utilities.isNotEmptyString(0));

• Read up
  Read up

Function trackProgress has 68 lines of code (exceeds 25 allowed). Consider refactoring.

Open

VASTTracker.prototype.trackProgress = function trackProgress(newProgressInMs) {
  var that = this;
  var events = [];
  var ONCE = true;
  var ALWAYS = false;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it("must not cancel the ads", function(){
        var adsCanceled = sinon.spy();
        player.on('vast.adsCancel', adsCanceled);
        player.vast.enable();
        player.trigger('vast.firstPlay');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it("must cancel the ads if the ads are not enabled", function(){
      var adsCanceled = sinon.spy();
      player.on('vast.adsCancel', adsCanceled);
      player.vast.disable();
      player.trigger('vast.firstPlay');

• Read up
  Read up

File http.spec.js has 274 lines of code (exceeds 250 allowed). Consider refactoring.

Open

var HttpRequest = require('utils/http').HttpRequest;
var HttpRequestError = require('utils/http').HttpRequestError;
var utilities = require('utils/utilityFunctions');

var testUtils = require('../test-utils');

Function playVPaidAd has 64 lines of code (exceeds 25 allowed). Consider refactoring.

Open

VPAIDIntegrator.prototype.playAd = function playVPaidAd(vastResponse, callback) {
  if (!(vastResponse instanceof VASTResponse)) {
    return callback(new VASTError('on VASTIntegrator.playAd, missing required VASTResponse'));
  }

Function run has 64 lines of code (exceeds 25 allowed). Consider refactoring.

Open

HttpRequest.prototype.run = function (method, url, callback, options) {
  sanityCheck(url, callback, options);
  var timeout, timeoutId;
  var xhr = this.createXhr();
  options = options || {};

File VASTIntegrator.js has 273 lines of code (exceeds 250 allowed). Consider refactoring.

Open

'use strict';

/**
 * Inner helper class that deals with the logic of the individual steps needed to setup an ad in the player.
 *

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it("must add the impressions to the response", function () {
        var wrapperXML = '<Wrapper>' +
          '<Impression id="1234"><![CDATA[http://Impression.url.track.com]]></Impression>' +
          '<Impression><![CDATA[http://Impression2.url.track.com]]></Impression>' +
          '<Impression id="1111"></Impression>' +

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it("must add the impressions to the response", function () {
        var impressionXML = '<Inline>' +
          '<Impression id="1234"><![CDATA[http://Impression.url.track.com]]></Impression>' +
          '<Impression><![CDATA[http://Impression2.url.track.com]]></Impression>' +
          '<Impression id="1111"></Impression>' +

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  function parseTrackingEvents(trackingEvents) {
    var trackings = [];
    if (utilities.isDefined(trackingEvents)) {
      trackingEvents = utilities.isArray(trackingEvents) ? trackingEvents : [trackingEvents];
      trackingEvents.forEach(function (trackingData) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  function parseMediaFiles(mediaFilesJxonTree) {
    var mediaFiles = [];
    if (utilities.isDefined(mediaFilesJxonTree)) {
      mediaFilesJxonTree = utilities.isArray(mediaFilesJxonTree) ? mediaFilesJxonTree : [mediaFilesJxonTree];

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

xml.encode = function encodeXML(str) {
  if (!utilities.isString(str)) return undefined;

  return str.replace(/&/g, '&')
    .replace(/</g, '&lt;')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

xml.decode = function decodeXML(str) {
  if (!utilities.isString(str)) return undefined;

  return str.replace(/'/g, "'")
    .replace(/"/g, '"')

• Read up
  Read up

Function restorePlayerSnapshot has 60 lines of code (exceeds 25 allowed). Consider refactoring.

Open

playerUtils.restorePlayerSnapshot = function restorePlayerSnapshot(player, snapshot) {
  var tech = player.el().querySelector('.vjs-tech');
  var attempts = 20; // the number of remaining attempts to restore the snapshot

  if (snapshot.nativePoster) {

Function playAd has 59 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function playAd(vastResponse, callback) {
    //TODO: Find a better way to stop the play. The 'playPrerollWaterfall' ends in an inconsistent situation
    //If the state is not 'preroll?' it means the ads were canceled therefore, we break the waterfall
    if (adsCanceled) {
      return;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        it("must add the trackingEvents", function(){
          var wrapperXML = '<Wrapper><Creatives><Creative><Linear><TrackingEvents>' +
            '<Tracking event="firstQuartile"><![CDATA[ http://www.tracking1.com ]]></Tracking>' +
            '</TrackingEvents></Linear></Creative></Creatives></Wrapper>';

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it("must add the trackings to the response", function () {
        var linearXML = '<Linear><TrackingEvents>' +
          '<Tracking event="firstQuartile"><![CDATA[ http://www.tracking1.com ]]></Tracking>' +
          '</TrackingEvents></Linear>';
        var linear = new Linear(xml.toJXONTree(linearXML));

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  function assertError(callback, msg, code) {
    var error = testUtils.firstArg(callback);
    assert.instanceOf(error, VASTError);
    assert.equal(error.message, "VAST Error: " + msg);
    if (code) {

• Read up
  Read up