Showing 62 of 62 total issues
Avoid variables with short names like $id. Configured minimum length is 3. Open
public function get($id, $throwException = true)- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The method get has a boolean flag argument $throwException, which is a certain sign of a Single Responsibility Principle violation. Open
public function get($id, $throwException = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid unused parameters such as '$key'. Open
public function remove($key)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid using static access to class 'mainaero\yii\gtm\widget\GTM' in method 'testShouldReturnRenderedDataPushSnippet'. Open
GTM::widget(['type' => 'dataLayerPush'])- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused parameters such as '$defaultValue'. Open
public function get($key, $defaultValue = null)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid using static access to class 'mainaero\yii\gtm\widget\GTM' in method 'testShouldReturnEmptyStringIfNoDataLayerPushItems'. Open
$this->assertEquals('', GTM::widget(['type' => 'dataLayerPush']));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Inline control structures are not allowed Open
if ($this->paramMissing($params))- Exclude checks
Inline control structures are not allowed Open
if ($id == 'session')- Exclude checks
Inline control structures are not allowed Open
if (empty($dataLayerPushItems))- Exclude checks
Inline control structures are not allowed Open
if ($this->type == self::TYPE_PUSH)- Exclude checks
Multi-line function call not indented correctly; expected 12 spaces but found 10 Open
$this->widget::widget(['type' => 'noscript'])- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 6 Open
);- Exclude checks
Multi-line function call not indented correctly; expected 14 spaces but found 12 Open
[- Exclude checks
Multi-line function call not indented correctly; expected 12 spaces but found 10 Open
'src/widget/views/dataLayerPush.php',- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 6 Open
);- Exclude checks
Multi-line function call not indented correctly; expected 14 spaces but found 12 Open
]- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 6 Open
);- Exclude checks
Multi-line function call not indented correctly; expected 12 spaces but found 10 Open
'src/widget/views/dataLayerPush.php',- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 6 Open
return $this->render($this->type, ['dataLayerPushItems' => $dataLayerPushItems]);- Exclude checks
Multi-line function call not indented correctly; expected 12 spaces but found 10 Open
[- Exclude checks