Sign upLogin

Maingron/MainOS

View on GitHub
Star

Showing 2,717 of 2,717 total issues

Avoid too many return statements within this function.
Open

            return ("(Ancient variable, use settings menu) <br>" + which + ": " + iofs.load(system.user.paths.userPath + "settings/" + which.split(" ")[0] + ".txt"));
Severity: Major
Found in Program Files/cmd/scripts.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return "Ran JS Command";
    Severity: Major
    Found in Program Files/cmd/scripts.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return(`${system.osDetails.name} Version: ${system.osDetails.version}`);
      Severity: Major
      Found in Program Files/cmd/scripts.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return "";
        Severity: Major
        Found in Program Files/cmd/scripts.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return "<b style='color:#f55; font-weight:inherit'>Command not found. Try /mc:help to get help.</b>";
          Severity: Major
          Found in Program Files/cmd/scripts.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return JSON.parse(iofs.load(path)).icon;
            Severity: Major
            Found in Program Files/Explorer/inner/modules/load_icons.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return "";
              Severity: Major
              Found in Program Files/cmd/scripts.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  return "Command not defined";
                Severity: Major
                Found in Program Files/cmd/scripts.js - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if(myProgram.sandbox == 1) {
            myWindow.classList.add("sandbox_l2");
            myWindow.frame.sandbox = "allow-scripts allow-forms";
        }
                  Severity: Minor
                  Found in functions-programs.js and 1 other location - About 30 mins to fix
                  functions-programs.js on lines 98..101

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function install has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function install() {
  if(!iofs.exists(storagePath)) {
    iofs.save(storagePath, "", "t=dir", 0, 1);
  }
                  Severity: Minor
                  Found in Program Files/simple cookieclicker/scripts.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function createNotificationIcon has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function createNotificationIcon() {
  if(parent.document.getElementById("taskbarrighticons")) {
    if(!parent.document.getElementById("notifications")) {
      let notificationIconTemp = document.createElement("a");
      notificationIconTemp.id = "notifications";
                  Severity: Minor
                  Found in Program Files/notifications/scripts.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function explorerdofile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function explorerdofile(path, action) { // Run if program is clicked
    var fileinfos = iofs.getInfos(path);
    let filename = fileinfos.name;
    var fileending = fileinfos.ending;
                  Severity: Minor
                  Found in Program Files/Explorer/inner/innerexplorer.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function loginUser has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function loginUser(name) {
    // only once document.body is loaded - temporary fix - sometimes document.body isn't loaded when browser is in background
    if(!document.body) {
        setTimeout(function() {
            loginUser(name);
                  Severity: Minor
                  Found in system/system_variable.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getWindowByMagic has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function getWindowByMagic(which) {
    var result;
    if(result == undefined || result == null || result == "") {
        result = getWindowByPid(which);
    }
                  Severity: Minor
                  Found in functions-programs.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function updateBottomInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function updateBottomInfo() {
    let amountFiles = 0;
    let amountDirs = 0;

    for(let file of filesListed) {
                  Severity: Minor
                  Found in Program Files/Explorer/inner/modules/bottom_info.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function register has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function register() {
    if(os?.document.getElementById("taskbar")) {
        if(!os.document.getElementById("start")) {
            let startButton = document.createElement("button");
            startButton.id = "start";
                  Severity: Minor
                  Found in Program Files/Explorer/Start/scripts.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Rule doesn't have all its properties in alphabetical order.
                  Open

                  .noborder iframe {
                  Severity: Minor
                  Found in style.css by csslint

                  Rule doesn't have all its properties in alphabetical order.
                  Open

                  .program {
                  Severity: Minor
                  Found in style.css by csslint

                  Adjoining classes: .program.closing
                  Open

                  .program.closing {
                  Severity: Minor
                  Found in style.css by csslint

                  Rule doesn't have all its properties in alphabetical order.
                  Open

                  .program.fullscreen {
                  Severity: Minor
                  Found in style.css by csslint
                  Severity
                  Category
                  Status
                  Source
                  Language