Sign upLogin

MakeYourLaws/MakeYourLaws

View on GitHub
Star
app/models/identity.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method by_omniauth has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def self.by_omniauth auth
    uid = (auth.provider == 'coinbase' ? auth.info.id  : auth.uid)
    id = Identity.find_or_initialize_by(provider: auth.provider, uid: uid)

    %w(name email nickname first_name last_name location description image phone urls).each do |x|
Severity: Minor
Found in app/models/identity.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method by_omniauth has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.by_omniauth auth
    uid = (auth.provider == 'coinbase' ? auth.info.id  : auth.uid)
    id = Identity.find_or_initialize_by(provider: auth.provider, uid: uid)

    %w(name email nickname first_name last_name location description image phone urls).each do |x|
Severity: Minor
Found in app/models/identity.rb - About 1 hr to fix
  • Create a ticket

    Method display_name has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def display_name
    if name
      nickname ? "#{name} (#{nickname})" : name
    else
      email || uid
    Severity: Minor
    Found in app/models/identity.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status