Sign upLogin

MakeYourLaws/rack-tor-tag

View on GitHub
Star

Showing 3 of 3 total issues

Method is_tor? has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    def is_tor? ip, env
      # We're a hidden service! Of course it's Tor.
      return true if env['HTTP_HOST'] =~ /\.onion\z/
      return false if (['localhost','127.0.0.1'].include? ip) or (['localhost','127.0.0.1'].include? env['HTTP_HOST'])
Severity: Minor
Found in lib/rack/tor_tag.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method is_tor? has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def is_tor? ip, env
      # We're a hidden service! Of course it's Tor.
      return true if env['HTTP_HOST'] =~ /\.onion\z/
      return false if (['localhost','127.0.0.1'].include? ip) or (['localhost','127.0.0.1'].include? env['HTTP_HOST'])
Severity: Minor
Found in lib/rack/tor_tag.rb - About 1 hr to fix
  • Create a ticket

    Avoid too many return statements within this method.
    Open

          return nil
    Severity: Major
    Found in lib/rack/tor_tag.rb - About 30 mins to fix
    • Create a ticket
      Severity
      Category
      Status
      Source
      Language