lib/manageiq/api/client/resource.rb
Method exec_action has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def exec_action(name, args = nil, &block)
args ||= {}
raise "Action #{name} parameters must be a hash" if !args.kind_of?(Hash)
action = find_action(name)
res = client.send(action.method, URI(action.href)) do- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Use yield instead of block.call. Open
Open
resource.merge!(block.call) if block- Read upRead up
- Exclude checks
This cop identifies the use of a &block parameter and block.call
where yield would do just as well.
Example:
# bad
def method(&block)
block.call
end
def another(&func)
func.call 1, 2, 3
end
# good
def method
yield
end
def another
yield 1, 2, 3
end