Sign upLogin

ManageIQ/manageiq-automation_engine

View on GitHub
Star
lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service.rb

Summary

Maintainability
A
55 mins
Test Coverage
A
93%

Use collect { |x| x.name.upcase } instead of collect method chain.
Open

      domains = @workspace.ae_user.current_tenant.ae_domains.collect(&:name).map(&:upcase)
Severity: Minor
Found in lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service.rb by rubocop

Use :@object instead of '@object'.
Open

        svc_obj.instance_variable_get('@object')
Severity: Minor
Found in lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service.rb by rubocop

Use collect { |x| x.name.upcase } instead of collect method chain.
Open

      domains = @workspace.ae_user.current_tenant.visible_domains.collect(&:name).map(&:upcase)
Severity: Minor
Found in lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service.rb by rubocop

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def owned_domain?(dom)
      domains = @workspace.ae_user.current_tenant.ae_domains.collect(&:name).map(&:upcase)
      return true if domains.include?(dom.upcase)

      $miq_ae_logger.warn("domain=#{dom} : is not editable", :resource_id => @workspace.find_miq_request_id)
Severity: Minor
Found in lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service.rb and 1 other location - About 25 mins to fix
lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service.rb on lines 404..409

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def visible_domain?(dom)
      domains = @workspace.ae_user.current_tenant.visible_domains.collect(&:name).map(&:upcase)
      return true if domains.include?(dom.upcase)

      $miq_ae_logger.warn("domain=#{dom} : is not viewable", :resource_id => @workspace.find_miq_request_id)
Severity: Minor
Found in lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service.rb and 1 other location - About 25 mins to fix
lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service.rb on lines 396..401

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Use Hash#compare_by_identity instead of using object_id for keys.
Open

      @@id_hash[obj.object_id] = obj
Severity: Minor
Found in lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service.rb by rubocop

Prefer using Hash#compare_by_identity rather than using object_id for hash keys.

This cop looks for hashes being keyed by objects' object_id, using one of these methods: key?, has_key?, fetch, [] and []=.

Safety:

This cop is unsafe. Although unlikely, the hash could store both object ids and other values that need be compared by value, and thus could be a false positive.

Furthermore, this cop cannot guarantee that the receiver of one of the methods (key?, etc.) is actually a hash.

Example:

# bad
hash = {}
hash[foo.object_id] = :bar
hash.key?(baz.object_id)

# good
hash = {}.compare_by_identity
hash[foo] = :bar
hash.key?(baz)

There are no issues that match your filters.

Category
Status