Sign upLogin

ManageIQ/manageiq-gems-pending

View on GitHub
Star
lib/gems/pending/util/win32/miq-wmi-linux.rb

Summary

Maintainability
A
2 hrs
Test Coverage
F
20%

Method get_windows_version has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def get_windows_version
    stdout_text = ""
    stderr_text = ""
    command_line = "winexe -U #{@server}/#{@username} //#{@server} \"cmd\""
    Open3.popen3(command_line) do |stdin, stdout, stderr|
Severity: Minor
Found in lib/gems/pending/util/win32/miq-wmi-linux.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method value_fixup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def value_fixup(wmi_class_name, values, col_names)
    fixup_column_name = case wmi_class_name
                        when "Win32_Process" then :OSName
                        when "Win32_OperatingSystem" then :Name
                        end
Severity: Minor
Found in lib/gems/pending/util/win32/miq-wmi-linux.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def associators_of(obj, assocClass = nil)
    wql = "ASSOCIATORS OF {#{obj.PATH__}}"
    wql += " WHERE AssocClass = #{assocClass}" unless assocClass.nil?
    wmi_object = run_query(wql)
    wmi_object.each { |s| yield s } if block_given?
Severity: Minor
Found in lib/gems/pending/util/win32/miq-wmi-linux.rb and 1 other location - About 25 mins to fix
lib/gems/pending/util/win32/miq-wmi-linux.rb on lines 114..119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def references_of(obj, resultClass = nil)
    wql = "REFERENCES OF {#{obj.PATH__}}"
    wql += " WHERE ResultClass = #{resultClass}" unless resultClass.nil?
    wmi_object = run_query(wql)
    wmi_object.each { |s| yield s } if block_given?
Severity: Minor
Found in lib/gems/pending/util/win32/miq-wmi-linux.rb and 1 other location - About 25 mins to fix
lib/gems/pending/util/win32/miq-wmi-linux.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Useless assignment to variable - version.
Open

    return version = stdout_text.split('\n').first.split('[')[1].split(']')[0].split(' ')[1] unless stdout_text.empty?
Severity: Minor
Found in lib/gems/pending/util/win32/miq-wmi-linux.rb by rubocop

Checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

NOTE: Given the assignment foo = 1, bar = 2, removing unused variables can lead to a syntax error, so this case is not autocorrected.

Safety:

This cop's autocorrection is unsafe because removing assignment from operator assignment can cause NameError if this assignment has been used to declare local variable. For example, replacing a ||= 1 to a || 1 may cause "undefined local variable or method `a' for main:Object (NameError)".

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

There are no issues that match your filters.

Category
Status