app/models/manageiq/providers/ibm_cloud/inventory/collector/vpc/target_collection.rb
Cyclomatic complexity for parse_targets! is too high. [14/11] Open
Open
def parse_targets!
# `target` here is an `InventoryRefresh::TargetCollection`. This contains two types of targets,
# `InventoryRefresh::Target` which is essentialy an association/manager_ref pair, or an ActiveRecord::Base
# type object like a Vm.
#- Read upRead up
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6Use filter_map instead. Open
Open
references(:vms).map do |ems_ref|
vpc.request(:get_instance, :id => ems_ref)
rescue IBMCloudSdkCore::ApiException
nil
end.compact- Exclude checks