Sign upLogin

ManageIQ/manageiq-providers-ibm_power_hmc

View on GitHub
Star

Showing 45 of 45 total issues

Duplicate branch body detected.
Open

    when "service processor failover" then "off"
Severity: Minor
Found in app/models/manageiq/providers/ibm_power_hmc/inventory/parser/infra_manager.rb by rubocop

Checks that there are no repeated bodies within if/unless, case-when, case-in and rescue constructs.

With IgnoreLiteralBranches: true, branches are not registered as offenses if they return a basic literal value (string, symbol, integer, float, rational, complex, true, false, or nil), or return an array, hash, regexp or range that only contains one of the above basic literal values.

With IgnoreConstantBranches: true, branches are not registered as offenses if they return a constant value.

Example:

# bad
if foo
  do_foo
  do_something_else
elsif bar
  do_foo
  do_something_else
end

# good
if foo || bar
  do_foo
  do_something_else
end

# bad
case x
when foo
  do_foo
when bar
  do_foo
else
  do_something_else
end

# good
case x
when foo, bar
  do_foo
else
  do_something_else
end

# bad
begin
  do_something
rescue FooError
  handle_error
rescue BarError
  handle_error
end

# good
begin
  do_something
rescue FooError, BarError
  handle_error
end

Example: IgnoreLiteralBranches: true

# good
case size
when "small" then 100
when "medium" then 250
when "large" then 1000
else 250
end

Example: IgnoreConstantBranches: true

# good
case size
when "small" then SMALL_SIZE
when "medium" then MEDIUM_SIZE
when "large" then LARGE_SIZE
else MEDIUM_SIZE
end

Use filter_map instead.
Open

      lpars.map do |lpar|
        [lpar.uuid, connection.vnic_dedicated(lpar.uuid)] unless lpar.vnic_dedicated_uuids.empty?
      rescue IbmPowerHmc::Connection::HttpNotFound
        nil
      rescue => e
Severity: Minor
Found in app/models/manageiq/providers/ibm_power_hmc/inventory/collector/infra_manager.rb by rubocop

Duplicate branch body detected.
Open

    when "on demand recovery"         then "off"
Severity: Minor
Found in app/models/manageiq/providers/ibm_power_hmc/inventory/parser/infra_manager.rb by rubocop

Checks that there are no repeated bodies within if/unless, case-when, case-in and rescue constructs.

With IgnoreLiteralBranches: true, branches are not registered as offenses if they return a basic literal value (string, symbol, integer, float, rational, complex, true, false, or nil), or return an array, hash, regexp or range that only contains one of the above basic literal values.

With IgnoreConstantBranches: true, branches are not registered as offenses if they return a constant value.

Example:

# bad
if foo
  do_foo
  do_something_else
elsif bar
  do_foo
  do_something_else
end

# good
if foo || bar
  do_foo
  do_something_else
end

# bad
case x
when foo
  do_foo
when bar
  do_foo
else
  do_something_else
end

# good
case x
when foo, bar
  do_foo
else
  do_something_else
end

# bad
begin
  do_something
rescue FooError
  handle_error
rescue BarError
  handle_error
end

# good
begin
  do_something
rescue FooError, BarError
  handle_error
end

Example: IgnoreLiteralBranches: true

# good
case size
when "small" then 100
when "medium" then 250
when "large" then 1000
else 250
end

Example: IgnoreConstantBranches: true

# good
case size
when "small" then SMALL_SIZE
when "medium" then MEDIUM_SIZE
when "large" then LARGE_SIZE
else MEDIUM_SIZE
end

Use filter_map instead.
Open

      metrics[ts] = counters.each_key.map do |key|
        val = get_sample_value(s, key)
        next if val.nil?

        [key, val]
Severity: Minor
Found in app/models/manageiq/providers/ibm_power_hmc/infra_manager/lpar.rb by rubocop

Use filter_map instead.
Open

      references(:resource_pools).map do |ems_ref|
        sys_uuid, pool_uuid = ems_ref.split("_")
        connection.shared_memory_pool(sys_uuid, pool_uuid)
      rescue IbmPowerHmc::Connection::HttpNotFound
        nil
Severity: Minor
Found in app/models/manageiq/providers/ibm_power_hmc/inventory/collector/target_collection.rb by rubocop
Severity
Category
Status
Source
Language