Sign upLogin

ManageIQ/manageiq-providers-ibm_power_vc

View on GitHub
Star

Showing 14 of 14 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const fetchImages = (provider) => {
    return new Promise((resolve, reject) => {
        API.get(API_CLOUD_TEMPL + '?expand=resources&attributes=id,name&filter[]=ems_id=' + provider).then(({resources}) => {
            let options = resources.map(({id, name}) => ({value: id, label: name}));
            resolve(options);
Severity: Major
Found in app/javascript/components/pvc-import-image-form/pvc-import-image-form.jsx and 1 other location - About 3 hrs to fix
app/javascript/components/pvc-import-image-form/pvc-import-image-form.jsx on lines 45..52

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const fetchBuckets = (provider) => {
    return new Promise((resolve, reject) => {
        API.get(API_OBJ_CONT + '?expand=resources&attributes=name,ems_id&filter[]=ems_id=' + provider).then(({resources}) => {
            let options = resources.map(({id, name}) => ({value: id, label: name}));
            resolve(options);
Severity: Major
Found in app/javascript/components/pvc-import-image-form/pvc-import-image-form.jsx and 1 other location - About 3 hrs to fix
app/javascript/components/pvc-import-image-form/pvc-import-image-form.jsx on lines 36..43

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    {
      component: componentTypes.SELECT,
      name: 'src_provider_id',
      id: 'src_provider_id',
      label: __('Choose source provider'),
Severity: Major
Found in app/javascript/components/pvc-import-image-form/pvc-import-image-form.schema.js and 1 other location - About 2 hrs to fix
app/javascript/components/pvc-import-image-form/pvc-import-image-form.schema.js on lines 31..41

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    {
      component: componentTypes.SELECT,
      name: 'obj_storage_id',
      id: 'obj_storage_id',
      label: __('Choose transient storage'),
Severity: Major
Found in app/javascript/components/pvc-import-image-form/pvc-import-image-form.schema.js and 1 other location - About 2 hrs to fix
app/javascript/components/pvc-import-image-form/pvc-import-image-form.schema.js on lines 7..17

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    {
      component: componentTypes.SELECT,
      name: 'bucket_id',
      key: `obj_storage_id-${state['obj_storage_id']}`,
      id: 'bucket_id',
Severity: Major
Found in app/javascript/components/pvc-import-image-form/pvc-import-image-form.schema.js and 1 other location - About 2 hrs to fix
app/javascript/components/pvc-import-image-form/pvc-import-image-form.schema.js on lines 19..29

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    {
      component: componentTypes.SELECT,
      name: 'src_image_id',
      key: `src_provider_id-${state['src_provider_id']}`,
      id: 'src_image_id',
Severity: Major
Found in app/javascript/components/pvc-import-image-form/pvc-import-image-form.schema.js and 1 other location - About 2 hrs to fix
app/javascript/components/pvc-import-image-form/pvc-import-image-form.schema.js on lines 43..53

Method pre_execute_poll has a Cognitive Complexity of 13 (exceeds 11 allowed). Consider refactoring.
Open

  def pre_execute_poll(*_args)
    ems = ExtManagementSystem.find(options[:src_provider_id])
    max_retries = 10
 
    message = nil
Severity: Minor
Found in app/models/manageiq/providers/ibm_power_vc/cloud_manager/pvc_image_import_workflow.rb - About 35 mins to fix

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    persister.vms_and_templates_advanced_settings.build(
      :resource     => server,
      :display_name => N_('Processing units'),
      :name         => 'processing_units',
      :value        => vm.attributes['vcpus'].to_s,
Severity: Minor
Found in app/models/manageiq/providers/ibm_power_vc/inventory/parser/cloud_manager.rb and 2 other locations - About 25 mins to fix
app/models/manageiq/providers/ibm_power_vc/inventory/parser/cloud_manager.rb on lines 49..57
app/models/manageiq/providers/ibm_power_vc/inventory/parser/cloud_manager.rb on lines 67..75

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    persister.vms_and_templates_advanced_settings.build(
      :resource     => server,
      :display_name => N_('Processors'),
      :name         => 'entitled_processors',
      :min          => vm.attributes['min_cpus'].to_s,
Severity: Minor
Found in app/models/manageiq/providers/ibm_power_vc/inventory/parser/cloud_manager.rb and 2 other locations - About 25 mins to fix
app/models/manageiq/providers/ibm_power_vc/inventory/parser/cloud_manager.rb on lines 49..57
app/models/manageiq/providers/ibm_power_vc/inventory/parser/cloud_manager.rb on lines 85..93

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    persister.vms_and_templates_advanced_settings.build(
      :resource     => server,
      :display_name => N_('Memory (MB)'),
      :name         => 'memory',
      :value        => vm.attributes['memory_mb'].to_s,
Severity: Minor
Found in app/models/manageiq/providers/ibm_power_vc/inventory/parser/cloud_manager.rb and 2 other locations - About 25 mins to fix
app/models/manageiq/providers/ibm_power_vc/inventory/parser/cloud_manager.rb on lines 67..75
app/models/manageiq/providers/ibm_power_vc/inventory/parser/cloud_manager.rb on lines 85..93

Similar blocks of code found in 2 locations. Consider refactoring.
Open

class ManageIQ::Providers::IbmPowerVc::StorageManager::SwiftManager < ManageIQ::Providers::Openstack::StorageManager::SwiftManager
  def self.ems_type
    @ems_type ||= "ibm_power_vc_swift".freeze
  end
 
 
Severity: Minor
Found in app/models/manageiq/providers/ibm_power_vc/storage_manager/swift_manager.rb and 1 other location - About 20 mins to fix
app/models/manageiq/providers/ibm_power_vc/storage_manager/cinder_manager.rb on lines 3..10

Similar blocks of code found in 2 locations. Consider refactoring.
Open

class ManageIQ::Providers::IbmPowerVc::StorageManager::CinderManager < ManageIQ::Providers::Openstack::StorageManager::CinderManager
  def self.ems_type
    @ems_type ||= "ibm_power_vc_cinder".freeze
  end
 
 
Severity: Minor
Found in app/models/manageiq/providers/ibm_power_vc/storage_manager/cinder_manager.rb and 1 other location - About 20 mins to fix
app/models/manageiq/providers/ibm_power_vc/storage_manager/swift_manager.rb on lines 3..10

metadata['rubygems_mfa_required'] must be set to 'true'.
Open

Gem::Specification.new do |spec|
  spec.name          = "manageiq-providers-ibm_power_vc"
  spec.version       = ManageIQ::Providers::IbmPowerVc::VERSION
  spec.authors       = ["ManageIQ Authors"]
 
 
Severity: Minor
Found in manageiq-providers-ibm_power_vc.gemspec by rubocop

Do not suppress exceptions.
Open

rescue LoadError
Severity: Minor
Found in Rakefile by rubocop
Severity
Category
Status
Source
Language