Sign upLogin

ManageIQ/manageiq-providers-openstack

View on GitHub
Star
app/models/manageiq/providers/openstack/cloud_manager/vm/associate_ip.rb

Summary

Maintainability
A
2 hrs
Test Coverage
C
76%

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  included do
    supports :associate_floating_ip do
      if cloud_tenant.nil? || cloud_tenant.floating_ips.empty?
        _("There are no %{floating_ips} available to this %{instance}.") % {
          :floating_ips => ui_lookup(:tables => "floating_ips"),
Severity: Minor
Found in app/models/manageiq/providers/openstack/cloud_manager/vm/associate_ip.rb and 1 other location - About 1 hr to fix
app/models/manageiq/providers/openstack/cloud_manager/vm/manage_security_groups.rb on lines 4..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  def raw_associate_floating_ip(floating_ip)
    ext_management_system.with_provider_connection(compute_connection_options) do |connection|
      connection.associate_address(ems_ref, floating_ip)
    end
  rescue => err
Severity: Major
Found in app/models/manageiq/providers/openstack/cloud_manager/vm/associate_ip.rb and 3 other locations - About 35 mins to fix
app/models/manageiq/providers/openstack/cloud_manager/vm/associate_ip.rb on lines 32..39
app/models/manageiq/providers/openstack/cloud_manager/vm/manage_security_groups.rb on lines 23..30
app/models/manageiq/providers/openstack/cloud_manager/vm/manage_security_groups.rb on lines 32..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  def raw_disassociate_floating_ip(floating_ip)
    ext_management_system.with_provider_connection(compute_connection_options) do |connection|
      connection.disassociate_address(ems_ref, floating_ip)
    end
  rescue => err
Severity: Major
Found in app/models/manageiq/providers/openstack/cloud_manager/vm/associate_ip.rb and 3 other locations - About 35 mins to fix
app/models/manageiq/providers/openstack/cloud_manager/vm/associate_ip.rb on lines 23..30
app/models/manageiq/providers/openstack/cloud_manager/vm/manage_security_groups.rb on lines 23..30
app/models/manageiq/providers/openstack/cloud_manager/vm/manage_security_groups.rb on lines 32..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status