Sign upLogin

ManageIQ/manageiq-providers-openstack

View on GitHub
Star
lib/manageiq/providers/openstack/legacy/test/compute_openstack_handle_example.rb

Summary

Maintainability
A
55 mins
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

def dump_attrs(obj, pref = "")
  unless obj.respond_to?(:attributes)
    puts "#{pref}#{obj.class.name} does not support attributes."
    return
  end
Severity: Minor
Found in lib/manageiq/providers/openstack/legacy/test/compute_openstack_handle_example.rb and 1 other location - About 55 mins to fix
lib/manageiq/providers/openstack/legacy/test/metering_event_monitor_example.rb on lines 9..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Redundant use of Object#to_s in puts.
Open

  puts err.to_s
Severity: Minor
Found in lib/manageiq/providers/openstack/legacy/test/compute_openstack_handle_example.rb by rubocop

Checks for string conversion in string interpolation, print, puts, and warn arguments, which is redundant.

Example:

# bad

"result is #{something.to_s}"
print something.to_s
puts something.to_s
warn something.to_s

Example:

# good

"result is #{something}"
print something
puts something
warn something

There are no issues that match your filters.

Category
Status