Sign upLogin

ManageIQ/manageiq-providers-ovirt

View on GitHub
Star
app/models/manageiq/providers/ovirt/infra_manager/metrics_capture.rb

Summary

Maintainability
A
0 mins
Test Coverage
B
80%

Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
Open

    rescue Exception => err
      _log.error("#{log_header} Unhandled exception during perf data collection: [#{err}], class: [#{err.class}]")
      _log.error("#{log_header}   Timings at time of error: #{Benchmark.current_realtime.inspect}")
      _log.log_backtrace(err)
      raise
Severity: Minor
Found in app/models/manageiq/providers/ovirt/infra_manager/metrics_capture.rb by rubocop

Checks for rescue blocks targeting the Exception class.

Example:

# bad

begin
  do_something
rescue Exception
  handle_exception
end

Example:

# good

begin
  do_something
rescue ArgumentError
  handle_exception
end

There are no issues that match your filters.

Category
Status