ManageIQ/manageiq-providers-ovirt

module ManageIQ::Providers::Ovirt
  class InfraManager::Refresher < ManageIQ::Providers::BaseManager::Refresher
    def collect_inventory_for_targets(ems, targets)
      inventory = inventory_from_api(ems)
      raise "Invalid RHEV server ip address." if inventory.api.nil?
 
      # TODO: before iterating over targets it would be good to check whether ExtMgmntSystem is part of it
      # TODO optimize not to fetch the same objects like clusters for multiple targets
 
      targets_with_data = targets.collect do |target|
        _log.info "Filtering inventory for #{target.class} [#{target.name}] id: [#{target.id}]..."
 
        ems_api_version = inventory.service.version_string.match(/([\d][\.\d]+)/)
        data = ems.class.module_parent::Inventory.build(ems, target)
 
        # TODO: remove when graph refresh supports ems updates
        ems.api_version = ems_api_version
        ems.save
 
        empty_hash_when_target_not_found!(target, data) if targeted_refresh?(target)
 
        data.instance_variable_set(:@ems_api_version, :api_version => ems_api_version)
 
        _log.info "Filtering inventory...Complete"
        [target, data]
      end
 
      ems.ensure_managers
 
      targets_with_data
    end
 
    def preprocess_targets
      @targets_by_ems_id.each do |ems_id, targets|
        ems = @ems_by_ems_id[ems_id]
Use `any?(ExtManagementSystem)` instead of block.
        ems_in_list = targets.any? { |t| t.kind_of?(ExtManagementSystem) }
 
        if ems_in_list
          _log.info "Defaulting to full refresh for EMS: [#{ems.name}], id: [#{ems.id}]." if targets.length > 1
          targets.clear << ems
        end
 
        all_targets, sub_ems_targets = targets.partition { |x| x.kind_of?(ExtManagementSystem) }
        unless sub_ems_targets.blank?
          ems_event_collection = InventoryRefresh::TargetCollection.new(:targets    => sub_ems_targets,
                                                                      :manager_id => ems_id)
          all_targets << ems_event_collection
        end
        @targets_by_ems_id[ems_id] = all_targets
      end
    end
 
Identical blocks of code found in 2 locations. Consider refactoring.
    def parse_targeted_inventory(ems, _target, inventory)
      log_header = format_ems_for_logging(ems)
      _log.debug "#{log_header} Parsing inventory..."
      hashes, = Benchmark.realtime_block(:parse_inventory) do
        inventory.parse
      end
      _log.debug "#{log_header} Parsing inventory...Complete"
 
      hashes
    end
 
    def post_process_refresh_classes
      [::VmOrTemplate, ::Host]
    end
 
    def inventory_from_api(ems)
      @ems = ems
      ems.class::Inventory.new(:ems => ems)
    end
 
    private
 
    def empty_hash_when_target_not_found!(target, data)
      empty_the_hash!(data) if corresponding_hashes_empty?(target, data)
    end
 
    def targeted_refresh?(target)
      target.kind_of?(VmOrTemplate) || target.kind_of?(Host)
    end
 
    def empty_the_hash!(data)
      data.each_key { |k| data[k] = nil }
    end
 
    def corresponding_hashes_empty?(target, data)
      case target
      when VmOrTemplate
        return data[:template].blank? if target.template?
        data[:vm].blank?
      when Host
        data[:host].blank?
      else
        false
      end
    end
  end
end