Sign upLogin

ManageIQ/manageiq-providers-red_hat_virtualization

View on GitHub
Star
app/models/manageiq/providers/redhat/infra_manager/event_fetcher.rb

Summary

Maintainability
A
0 mins
Test Coverage
F
56%

Avoid hard coding large quantities of data in code. Prefer reading the data from an external source.
Open

  EVENT_CODES = {
    # Code   Description
    0     => "UNASSIGNED",
    1     => "VDC_START",
    2     => "VDC_STOP",
Severity: Minor
Found in app/models/manageiq/providers/redhat/infra_manager/event_fetcher.rb by rubocop

Checks for literals with extremely many entries. This is indicative of configuration or data that may be better extracted somewhere else, like a database, fetched from an API, or read from a non-code file (CSV, JSON, YAML, etc.).

Example:

# bad
# Huge Array literal
[1, 2, '...', 999_999_999]

# bad
# Huge Hash literal
{ 1 => 1, 2 => 2, '...' => '...', 999_999_999 => 999_999_999}

# bad
# Huge Set "literal"
Set[1, 2, '...', 999_999_999]

# good
# Reasonably sized Array literal
[1, 2, '...', 10]

# good
# Reading huge Array from external data source
# File.readlines('numbers.txt', chomp: true).map!(&:to_i)

# good
# Reasonably sized Hash literal
{ 1 => 1, 2 => 2, '...' => '...', 10 => 10}

# good
# Reading huge Hash from external data source
CSV.foreach('numbers.csv', headers: true).each_with_object({}) do |row, hash|
  hash[row["key"].to_i] = row["value"].to_i
end

# good
# Reasonably sized Set "literal"
Set[1, 2, '...', 10]

# good
# Reading huge Set from external data source
SomeFramework.config_for(:something)[:numbers].to_set

There are no issues that match your filters.

Category
Status