Sign upLogin

ManageIQ/manageiq-providers-vmware

View on GitHub
Star
app/models/manageiq/providers/vmware/infra_manager/inventory/collector/property_collector.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
96%

Method get_array_entry has a Cognitive Complexity of 13 (exceeds 11 allowed). Consider refactoring.
Open

  def get_array_entry(array, key)
    return nil, nil unless array.kind_of?(Array)

    array.each_index do |n|
      array_entry = array[n]
Severity: Minor
Found in app/models/manageiq/providers/vmware/infra_manager/inventory/collector/property_collector.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_prop_change has a Cognitive Complexity of 12 (exceeds 11 allowed). Consider refactoring.
Open

  def process_prop_change(prop_hash, prop_change)
    h, prop_str = hash_target(prop_hash, prop_change.name)
    tag, key    = tag_and_key(prop_str)

    case prop_change.op
Severity: Minor
Found in app/models/manageiq/providers/vmware/infra_manager/inventory/collector/property_collector.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use :key instead of "key".
Open

      entry_key = array_entry.respond_to?("key") ? array_entry.key : array_entry
Severity: Minor
Found in app/models/manageiq/providers/vmware/infra_manager/inventory/collector/property_collector.rb by rubocop

Use string as argument instead of regexp.
Open

    prop_path.split(//).each do |c|
Severity: Minor
Found in app/models/manageiq/providers/vmware/infra_manager/inventory/collector/property_collector.rb by rubocop

There are no issues that match your filters.

Category
Status