Sign upLogin

ManageIQ/manageiq-providers-vmware

View on GitHub
Star
app/models/manageiq/providers/vmware/infra_manager/inventory/parser.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
90%

Cyclomatic complexity for parse_portgroups_internal is too high. [12/11]
Open

  def parse_portgroups_internal(object, props)
    return if Array.wrap(props[:tag]).detect { |tag| tag.key == "SYSTEM/DVS.UPLINKPG" }

    ref  = object._ref
    uid  = props.fetch_path(:config, :key)
Severity: Minor
Found in app/models/manageiq/providers/vmware/infra_manager/inventory/parser.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

There are no issues that match your filters.

Category
Status