Sign upLogin

ManageIQ/manageiq-smartstate

View on GitHub
Star
lib/VolumeManager/LVM/thin/data_map.rb

Summary

Maintainability
A
25 mins
Test Coverage
F
37%

Method data_block has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
Open

    def data_block(device_block)
      device_blocks.reverse.each do |map_device_block|
        if map_device_block <= device_block
          entry = entry_for(map_device_block)
          return entry.data_block(device_block) if entry.is_a?(DataMap)
Severity: Minor
Found in lib/VolumeManager/LVM/thin/data_map.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use reverse_each instead of reverse.each.
Open

      device_blocks.reverse.each do |map_device_block|
Severity: Minor
Found in lib/VolumeManager/LVM/thin/data_map.rb by rubocop

This cop is used to identify usages of reverse.each and change them to use reverse_each instead.

Example:

# bad
[].reverse.each

# good
[].reverse_each

There are no issues that match your filters.

Category
Status