Sign upLogin

ManageIQ/manageiq-smartstate

View on GitHub
Star
lib/disk/MiqDisk.rb

Summary

Maintainability
B
5 hrs
Test Coverage
D
69%

File MiqDisk.rb has 251 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'binary_struct'
require 'disk/DiskProbe'

class MiqDisk
  attr_accessor :diskType, :dInfo, :blockSize, :pvObj, :fs
Severity: Minor
Found in lib/disk/MiqDisk.rb - About 2 hrs to fix

Method initialize has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(dm, dInfo, pType, *lbaSE)
    extend(dm) unless dm.nil?
    @dModule  = dm
    @dInfo    = dInfo
    @partType = pType
Severity: Minor
Found in lib/disk/MiqDisk.rb - About 1 hr to fix

Method getDisk has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
Open

  def self.getDisk(dInfo, probes = nil)
    $log.debug "MiqDisk::getDisk: baseOnly = #{dInfo.baseOnly}" if $log
    if (dm = DiskProbe.getDiskMod(dInfo, probes))
      d = new(dm, dInfo.clone, 0)
      if dInfo.baseOnly
Severity: Minor
Found in lib/disk/MiqDisk.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
Open

  def initialize(dm, dInfo, pType, *lbaSE)
    extend(dm) unless dm.nil?
    @dModule  = dm
    @dInfo    = dInfo
    @partType = pType
Severity: Minor
Found in lib/disk/MiqDisk.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def initialize(baseDisk, pType, lbaStart, lbaEnd, partNum)
Severity: Minor
Found in lib/disk/MiqDisk.rb - About 35 mins to fix

There are no issues that match your filters.

Category
Status