Sign upLogin

ManageIQ/manageiq-smartstate

View on GitHub
Star
lib/disk/modules/QcowDisk.rb

Summary

Maintainability
D
1 day
Test Coverage

File QcowDisk.rb has 555 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'disk/modules/MiqLargeFile'
require 'memory_buffer'
require 'binary_struct'

require 'zlib'
Severity: Major
Found in lib/disk/modules/QcowDisk.rb - About 1 day to fix

Method read_sectors has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def read_sectors(sector_num, nb_sectors)
    buf = ""

    while nb_sectors > 0
      index_in_cluster = sector_num & (cluster_sectors - 1)
Severity: Minor
Found in lib/disk/modules/QcowDisk.rb - About 1 hr to fix

Method dump has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def dump
    out = "\#<#{self.class}:0x#{'%08x' % object_id}>\n"
    out << "Version                  : #{version}\n"
    out << "Image Size               : #{size}\n"
    out << "Backing File Name        : #{backing_file_name}\n"
Severity: Minor
Found in lib/disk/modules/QcowDisk.rb - About 1 hr to fix

Method read_sectors has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
Open

  def read_sectors(sector_num, nb_sectors)
    buf = ""

    while nb_sectors > 0
      index_in_cluster = sector_num & (cluster_sectors - 1)
Severity: Minor
Found in lib/disk/modules/QcowDisk.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method count_contiguous_clusters has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def count_contiguous_clusters(nb_clusters, cluster_size, l2_table, l2_index, start = 0)
Severity: Minor
Found in lib/disk/modules/QcowDisk.rb - About 35 mins to fix

Useless assignment to variable - h.
Open

      h = nil
Severity: Minor
Found in lib/disk/modules/QcowDisk.rb by rubocop

Checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

NOTE: Given the assignment foo = 1, bar = 2, removing unused variables can lead to a syntax error, so this case is not autocorrected.

Safety:

This cop's autocorrection is unsafe because removing assignment from operator assignment can cause NameError if this assignment has been used to declare local variable. For example, replacing a ||= 1 to a || 1 may cause "undefined local variable or method `a' for main:Object (NameError)".

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

There are no issues that match your filters.

Category
Status