Method probe has a Cognitive Complexity of 22 (exceeds 8 allowed). Consider refactoring. Open
def self.probe(ostruct)
return nil unless ostruct.fileName
ext = File.extname(ostruct.fileName).downcase
return nil unless ext.length.zero?- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Cyclomatic complexity for probe is too high. [12/11] Open
def self.probe(ostruct)
return nil unless ostruct.fileName
ext = File.extname(ostruct.fileName).downcase
return nil unless ext.length.zero?- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6Avoid too many return statements within this method. Open
return RAW_MOD if desc[:format].to_s.include?('RAW')- Create a ticketCreate a ticket
Avoid too many return statements within this method. Open
return QCOW_MOD if desc[:format].to_s.include?('COW')- Create a ticketCreate a ticket
Avoid too many return statements within this method. Open
return DESC_MOD- Create a ticketCreate a ticket
Avoid too many return statements within this method. Open
return RAW_MOD if desc[:format].to_s.include?('RAW')- Create a ticketCreate a ticket
Avoid too many return statements within this method. Open
return QCOW_MOD if desc[:format].to_s.include?('COW')- Create a ticketCreate a ticket
Avoid too many return statements within this method. Open
return nil unless File.exist?(descriptor_file)- Create a ticketCreate a ticket
Useless assignment to variable - value. Open
desc[key.downcase.to_sym] = value = value.join('=')- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks for every useless assignment to local variable in every
scope.
The basic idea for this cop was from the warning of ruby -cw:
assigned but unused variable - fooCurrently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.
NOTE: Given the assignment foo = 1, bar = 2, removing unused variables
can lead to a syntax error, so this case is not autocorrected.
Safety:
This cop's autocorrection is unsafe because removing assignment from
operator assignment can cause NameError if this assignment has been used to declare
local variable. For example, replacing a ||= 1 to a || 1 may cause
"undefined local variable or method `a' for main:Object (NameError)".
Example:
# bad
def some_method
some_var = 1
do_something
endExample:
# good
def some_method
some_var = 1
do_something(some_var)
end