Sign upLogin

ManageIQ/manageiq-smartstate

View on GitHub
Star
lib/fs/MiqFS/modules/XFS.rb

Summary

Maintainability
A
55 mins
Test Coverage

Avoid too many return statements within this method.
Open

    return nil if dir.nil?
Severity: Major
Found in lib/fs/MiqFS/modules/XFS.rb - About 30 mins to fix

Method ifs_getFile has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
Open

  def ifs_getFile(p, miqfs = nil)
    # If this is being called from a FileObject instance, then MiqFS owns contained instance members.
    # If this is being called from an XFS module method, then self owns contained instance members.
    miqfs = self if miqfs.nil?
Severity: Minor
Found in lib/fs/MiqFS/modules/XFS.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status