ManageIQ/manageiq-smartstate

View on GitHub
lib/fs/fat32/boot_sect.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File boot_sect.rb has 278 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'binary_struct'
require 'memory_buffer'

# ////////////////////////////////////////////////////////////////////////////
# // Data definitions.
Severity: Minor
Found in lib/fs/fat32/boot_sect.rb - About 2 hrs to fix

Cyclomatic complexity for initialize is too high. [17/11]
Open

    def initialize(stream)
      raise "Nil stream" if stream.nil?

      # Init all.
      @bytesPerSector = 0; @bytesPerCluster = 0; @fatBase = 0
Severity: Minor
Found in lib/fs/fat32/boot_sect.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Method dump has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def dump
      out = "\#<#{self.class}:0x#{'%08x' % object_id}>\n"
      out += "Jump boot (hex)   : #{'%02x %02x %02x' % @bs['jmp_boot'].unpack('C3')}\n"
      out += "OEM Name          : #{@bs['oem_name']}\n"
      out += "Bytes per sector  : #{@bs['bytes_per_sec']}\n"
Severity: Minor
Found in lib/fs/fat32/boot_sect.rb - About 1 hr to fix

Method initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(stream)
      raise "Nil stream" if stream.nil?

      # Init all.
      @bytesPerSector = 0; @bytesPerCluster = 0; @fatBase = 0
Severity: Minor
Found in lib/fs/fat32/boot_sect.rb - About 1 hr to fix

Method initialize has a Cognitive Complexity of 13 (exceeds 8 allowed). Consider refactoring.
Open

    def initialize(stream)
      raise "Nil stream" if stream.nil?

      # Init all.
      @bytesPerSector = 0; @bytesPerCluster = 0; @fatBase = 0
Severity: Minor
Found in lib/fs/fat32/boot_sect.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method wipeChain has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
Open

    def wipeChain(clus)
      loop do
        nxt = getFatEntry(clus)
        putFatEntry(clus, 0)
        break if nxt == 0 # A 0 entry means FAT is inconsistent. Chkdsk may report lost clusters.
Severity: Minor
Found in lib/fs/fat32/boot_sect.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Wrap expressions with varying precedence with parentheses to avoid ambiguity.
Open

      @bs['res_sec'] * @bytesPerSector + @fatSize * @bs['num_fats'] + (clus - 2) * @bytesPerCluster
Severity: Minor
Found in lib/fs/fat32/boot_sect.rb by rubocop

Looks for expressions containing multiple binary operators where precedence is ambiguous due to lack of parentheses. For example, in 1 + 2 * 3, the multiplication will happen before the addition, but lexically it appears that the addition will happen first.

The cop does not consider unary operators (ie. !a or -b) or comparison operators (ie. a =~ b) because those are not ambiguous.

NOTE: Ranges are handled by Lint/AmbiguousRange.

Example:

# bad
a + b * c
a || b && c
a ** b + c

# good (different precedence)
a + (b * c)
a || (b && c)
(a ** b) + c

# good (same precedence)
a + b + c
a * b / c % d

Wrap expressions with varying precedence with parentheses to avoid ambiguity.
Open

      @stream.seek(@fatBase + FAT_ENTRY_SIZE * clus)
Severity: Minor
Found in lib/fs/fat32/boot_sect.rb by rubocop

Looks for expressions containing multiple binary operators where precedence is ambiguous due to lack of parentheses. For example, in 1 + 2 * 3, the multiplication will happen before the addition, but lexically it appears that the addition will happen first.

The cop does not consider unary operators (ie. !a or -b) or comparison operators (ie. a =~ b) because those are not ambiguous.

NOTE: Ranges are handled by Lint/AmbiguousRange.

Example:

# bad
a + b * c
a || b && c
a ** b + c

# good (different precedence)
a + (b * c)
a || (b && c)
(a ** b) + c

# good (same precedence)
a + b + c
a * b / c % d

Wrap expressions with varying precedence with parentheses to avoid ambiguity.
Open

      @bs['res_sec'] * @bytesPerSector + @fatSize * @bs['num_fats'] + (clus - 2) * @bytesPerCluster
Severity: Minor
Found in lib/fs/fat32/boot_sect.rb by rubocop

Looks for expressions containing multiple binary operators where precedence is ambiguous due to lack of parentheses. For example, in 1 + 2 * 3, the multiplication will happen before the addition, but lexically it appears that the addition will happen first.

The cop does not consider unary operators (ie. !a or -b) or comparison operators (ie. a =~ b) because those are not ambiguous.

NOTE: Ranges are handled by Lint/AmbiguousRange.

Example:

# bad
a + b * c
a || b && c
a ** b + c

# good (different precedence)
a + (b * c)
a || (b && c)
(a ** b) + c

# good (same precedence)
a + b + c
a * b / c % d

Wrap expressions with varying precedence with parentheses to avoid ambiguity.
Open

      @stream.seek(@fatBase + FAT_ENTRY_SIZE * clus)
Severity: Minor
Found in lib/fs/fat32/boot_sect.rb by rubocop

Looks for expressions containing multiple binary operators where precedence is ambiguous due to lack of parentheses. For example, in 1 + 2 * 3, the multiplication will happen before the addition, but lexically it appears that the addition will happen first.

The cop does not consider unary operators (ie. !a or -b) or comparison operators (ie. a =~ b) because those are not ambiguous.

NOTE: Ranges are handled by Lint/AmbiguousRange.

Example:

# bad
a + b * c
a || b && c
a ** b + c

# good (different precedence)
a + (b * c)
a || (b && c)
(a ** b) + c

# good (same precedence)
a + b + c
a * b / c % d

Wrap expressions with varying precedence with parentheses to avoid ambiguity.
Open

      @bs['res_sec'] * @bytesPerSector + @fatSize * @bs['num_fats'] + (clus - 2) * @bytesPerCluster
Severity: Minor
Found in lib/fs/fat32/boot_sect.rb by rubocop

Looks for expressions containing multiple binary operators where precedence is ambiguous due to lack of parentheses. For example, in 1 + 2 * 3, the multiplication will happen before the addition, but lexically it appears that the addition will happen first.

The cop does not consider unary operators (ie. !a or -b) or comparison operators (ie. a =~ b) because those are not ambiguous.

NOTE: Ranges are handled by Lint/AmbiguousRange.

Example:

# bad
a + b * c
a || b && c
a ** b + c

# good (different precedence)
a + (b * c)
a || (b && c)
(a ** b) + c

# good (same precedence)
a + b + c
a * b / c % d

There are no issues that match your filters.

Category
Status