ManageIQ/manageiq-smartstate

View on GitHub
lib/metadata/ScanProfile/modules/HostScanItemFile.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method parse_data has a Cognitive Complexity of 21 (exceeds 8 allowed). Consider refactoring.
Open

  def parse_data(ssu, data, &_blk)
    if data.nil?
      d = scan_definition

      st = Time.now
Severity: Minor
Found in lib/metadata/ScanProfile/modules/HostScanItemFile.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for parse_data is too high. [16/11]
Open

  def parse_data(ssu, data, &_blk)
    if data.nil?
      d = scan_definition

      st = Time.now

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Method parse_data has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def parse_data(ssu, data, &_blk)
    if data.nil?
      d = scan_definition

      st = Time.now
Severity: Minor
Found in lib/metadata/ScanProfile/modules/HostScanItemFile.rb - About 1 hr to fix

Use filter_map instead.
Open

      md5_files = files.collect { |f| f[:name] if f[:rsc_type] == 'file' }.compact

Check block argument explicitly instead of using block_given?.
Open

      yield({:msg => 'Scanning Profile-File'}) if block_given?

Use filter_map instead.
Open

      cat_files = d["stats"].collect { |s| s["target"] if s["content"] }.compact.uniq

There are no issues that match your filters.

Category
Status