Sign upLogin

ManageIQ/manageiq-smartstate

View on GitHub
Star
lib/metadata/ScanProfile/modules/VmScanItemFile.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method parse_data has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
Open

  def parse_data(vm, data, &_blk)
    if data.nil?
      st = Time.now
      $log.info "Scanning [Profile-Files] information."
      yield({:msg => 'Scanning Profile-File'}) if block_given?
Severity: Minor
Found in lib/metadata/ScanProfile/modules/VmScanItemFile.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Check block argument explicitly instead of using block_given?.
Open

      yield({:msg => 'Scanning Profile-File'}) if block_given?
Severity: Minor
Found in lib/metadata/ScanProfile/modules/VmScanItemFile.rb by rubocop

Do not suppress exceptions.
Open

        rescue
Severity: Minor
Found in lib/metadata/ScanProfile/modules/VmScanItemFile.rb by rubocop

Checks for rescue blocks with no body.

Example:

# bad
def some_method
  do_something
rescue
end

# bad
begin
  do_something
rescue
end

# good
def some_method
  do_something
rescue
  handle_exception
end

# good
begin
  do_something
rescue
  handle_exception
end

Example: AllowComments: true (default)

# good
def some_method
  do_something
rescue
  # do nothing
end

# good
begin
  do_something
rescue
  # do nothing
end

Example: AllowComments: false

# bad
def some_method
  do_something
rescue
  # do nothing
end

# bad
begin
  do_something
rescue
  # do nothing
end

Example: AllowNil: true (default)

# good
def some_method
  do_something
rescue
  nil
end

# good
begin
  do_something
rescue
  # do nothing
end

# good
do_something rescue nil

Example: AllowNil: false

# bad
def some_method
  do_something
rescue
  nil
end

# bad
begin
  do_something
rescue
  nil
end

# bad
do_something rescue nil

There are no issues that match your filters.

Category
Status