ManageIQ/manageiq-smartstate

View on GitHub
lib/metadata/ScanProfile/modules/VmScanItemNteventlog.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method parse_data has a Cognitive Complexity of 14 (exceeds 8 allowed). Consider refactoring.
Open

  def parse_data(vm, data, &_blk)
    if data.nil?
      d = scan_definition
      if d[:data].nil?
        if vm.rootTrees[0].guestOS == "Windows"
Severity: Minor
Found in lib/metadata/ScanProfile/modules/VmScanItemNteventlog.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid more than 3 levels of block nesting.
Open

          rescue => err
            $log.error "Win32EventLog: #{err}"
            $log.error err.backtrace.join("\n")

Checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Avoid more than 3 levels of block nesting.
Open

            yield({:msg => 'Scanning Profile-EventLogs'}) if block_given?

Checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Avoid more than 3 levels of block nesting.
Open

          rescue MiqException::NtEventLogFormat
            $log.warn $!.to_s

Checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Check block argument explicitly instead of using block_given?.
Open

            yield({:msg => 'Scanning Profile-EventLogs'}) if block_given?

There are no issues that match your filters.

Category
Status