Sign upLogin

ManageIQ/manageiq-smartstate

View on GitHub
Star
lib/metadata/linux/LinuxUtils.rb

Summary

Maintainability
C
7 hrs
Test Coverage
F
26%

Method octal_to_permissions has a Cognitive Complexity of 35 (exceeds 8 allowed). Consider refactoring.
Open

    def self.octal_to_permissions(octal, ftype = nil)
      perms = ""

      unless ftype.nil?
        ftype = ftype[0, 1]
Severity: Minor
Found in lib/metadata/linux/LinuxUtils.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for octal_to_permissions is too high. [19/11]
Open

    def self.octal_to_permissions(octal, ftype = nil)
      perms = ""

      unless ftype.nil?
        ftype = ftype[0, 1]
Severity: Minor
Found in lib/metadata/linux/LinuxUtils.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Method parse_chkconfig_list has a Cognitive Complexity of 15 (exceeds 8 allowed). Consider refactoring.
Open

    def self.parse_chkconfig_list(lines)
      ret = []
      return ret if lines.nil? || lines.empty?

      lines.each_line do |line|
Severity: Minor
Found in lib/metadata/linux/LinuxUtils.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method permissions_to_octal has a Cognitive Complexity of 13 (exceeds 8 allowed). Consider refactoring.
Open

    def self.permissions_to_octal(perms)
      if perms.length == 9
        ftype = nil
      elsif perms.length == 10
        ftype = perms[0, 1]
Severity: Minor
Found in lib/metadata/linux/LinuxUtils.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_network_interface_list has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
Open

    def self.parse_network_interface_list(lines)
      return [] if lines.blank?

      interfaces = {}
      interface = {}
Severity: Minor
Found in lib/metadata/linux/LinuxUtils.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use filter_map instead.
Open

      lines.each_line.map do |line|
        line = line.chomp
        parts = line.split(/^(\S+)\s/)

        name, = parts[1]
Severity: Minor
Found in lib/metadata/linux/LinuxUtils.rb by rubocop

Avoid immutable Array literals in loops. It is better to extract it into a local variable or a constant.
Open

        octal[0] += 2**(2 - (i / 3)) if %w(s t S T).include?(c)
Severity: Minor
Found in lib/metadata/linux/LinuxUtils.rb by rubocop

Use filter_map instead.
Open

      lines.each_line.map do |line|
        line = line.chomp
        parts = line.split(' ')
        next if (/^.*?\.service$/ =~ parts[0]).nil?
Severity: Minor
Found in lib/metadata/linux/LinuxUtils.rb by rubocop

Use !String#include? instead of a regex match with literal-only pattern.
Open

            'enabled' => service[2] !~ /disabled/
Severity: Minor
Found in lib/metadata/linux/LinuxUtils.rb by rubocop

Use string as argument instead of regexp.
Open

      perms.split(//).each_with_index do |c, i|
Severity: Minor
Found in lib/metadata/linux/LinuxUtils.rb by rubocop

Avoid immutable Array literals in loops. It is better to extract it into a local variable or a constant.
Open

        octal[i / 3 + 1] += 2**(2 - (i % 3)) unless %w(- S T).include?(c)
Severity: Minor
Found in lib/metadata/linux/LinuxUtils.rb by rubocop

Wrap expressions with varying precedence with parentheses to avoid ambiguity.
Open

        octal[i / 3 + 1] += 2**(2 - (i % 3)) unless %w(- S T).include?(c)
Severity: Minor
Found in lib/metadata/linux/LinuxUtils.rb by rubocop

Looks for expressions containing multiple binary operators where precedence is ambiguous due to lack of parentheses. For example, in 1 + 2 * 3, the multiplication will happen before the addition, but lexically it appears that the addition will happen first.

The cop does not consider unary operators (ie. !a or -b) or comparison operators (ie. a =~ b) because those are not ambiguous.

NOTE: Ranges are handled by Lint/AmbiguousRange.

Example:

# bad
a + b * c
a || b && c
a ** b + c

# good (different precedence)
a + (b * c)
a || (b && c)
(a ** b) + c

# good (same precedence)
a + b + c
a * b / c % d

There are no issues that match your filters.

Category
Status